Re: [RFC/RFA] Cleaner handling of character entities ?

Daniel Jacobowitz
2006-05-05T18:29:04Z

On Fri, May 05, 2006 at 11:23:51AM -0700, Joel Brobecker wrote:
> I think the attached patch improves the situation in terms of making
> things cleaner in the case of dwarf2, without impacting targets that
> still use older debugging format like stabs.
>
> 2006-05-05 Joel Brobecker <brobecker@adacore.com>
>
> * dwarf2read.c (read_base_type): Set code to TYPE_CODE_CHAR
> for char and unsigned char types.
> * ada-lang.c (ada_is_character_type): Always return true if
> the type code is TYPE_CODE_CHAR.
> * c-valprint.c (c_val_print): Print arrays whose element type
> code is TYPE_CODE_CHAR as strings.
>
> Tested on x86-linux, with GCC 3.4 (dwarf2, stabs+), GCC 4.1 (dwarf2).
> No regression.
>
> What do you guys think? Wouldn't that be a step forward?

I really suspect this impacts the existing producers in some way,
though I don't know exactly how. You should take a look at the most
recent Modula-2 patch, and the discussion around the previous posting
of it, which contained very similar changes (conditionalized for M2).

--
Daniel Jacobowitz
CodeSourcery