On Friday 05 May 2006 17:51, Daniel Jacobowitz wrote:
> On Fri, May 05, 2006 at 11:54:08AM +0400, Vladimir Prus wrote:
> > Hi,
> > attached patch stops -stack-list-frames from emitting error when the
> > HIGH_FRAME parameter is larger than the actual number of frames.
>
> As far as I'm concerned, this change is reasonable; but let's wait
> until next week to see if anyone else has a reason for the current
> behavior. (I don't think anyone will; just being cautious.)
>
> > ? .gdbinit
>
> Please trim all this next time :-)

Sure, sorry.

> > ===================================================================
> > RCS file: /cvs/src/src/gdb/ChangeLog,v
> > retrieving revision 1.7714
> > diff -u -r1.7714 ChangeLog
> > --- ChangeLog	3 May 2006 22:59:38 -0000	1.7714
> > +++ ChangeLog	5 May 2006 07:50:28 -0000
> > @@ -1,3 +1,10 @@
>
> It's usually better to include ChangeLog entries as text, not as diffs.
> When they're diffs, they invariably generate patch rejects later on.

The reason I've included them in patch is that I've learned about Emacs's 
add-change-log-entry command, which conveniently adds entry to existing 
file ;-) So, in case if there are several ChangeLog files in patch, I should 
put those entries separately, and indicate which file each entry goes to, 
right?

> > +2006-05-05  Vladimir Prus  <ghost@lvk.cs.msu.su>
> > +
> > +	* mi/mi-cmd-stack.c (mi_cmd_stack_list_frames): Don't emit error
> > +	if high requested frame number is larger then number of available
> > +	frames.
> > +
> > +
>
> Just one blank line between entries, please.

Ok.

> > -are equal, it shows the single frame at the corresponding level.
> > +are equal, it shows the single frame at the corresponding level. It is
> > +an error if @var{low-frame} is larger than the actual number of frames.
> > On +the other hand, @var{high-frame} may be larger then the actual number
> > of +frames, in which case only existing frames will be returned.
>
> Two spaces after periods.  

Ok.

>
> > Index: testsuite/ChangeLog
> > ===================================================================
> > RCS file: /cvs/src/src/gdb/testsuite/ChangeLog,v
> > retrieving revision 1.1208
> > diff -u -r1.1208 ChangeLog
> > --- testsuite/ChangeLog	1 May 2006 22:21:35 -0000	1.1208
> > +++ testsuite/ChangeLog	5 May 2006 07:50:34 -0000
> > @@ -1,3 +1,9 @@
> > +2006-05-05  Vladimir Prus  <ghost@lvk.cs.msu.su>
> > +
> > +	* gdb.mi/mi2-stack.exp (test_stack_frame_listing): Test that
> > +	HIGH_FRAME argument to -stack-list-locals can be larger than
> > +	the number of frames.
>
> Please don't add new tests to just mi2-stack.exp.  I don't much care
> whether mi2-stack.exp is updated or not, but when we finalize mi3 and
> create mi3-* tests, they're going to be copied from mi-*.  So it's
> important that new tests go there also.

So, what's the point of mi2 tests at all? 
In any case, there's revised patch:

./Changelog:
2006-05-05  Vladimir Prus  <ghost@lvk.cs.msu.su>

	* mi/mi-cmd-stack.c (mi_cmd_stack_list_frames): Don't emit error
	if high requested frame number is larger then number of available 
	frames.


doc/ChangeLog
2006-05-05  Vladimir Prus  <ghost@lvk.cs.msu.su>

	* gdb.texinfo (GDB/MI Stack Manipulation): Mention that
	-stack-list-locals HIGH_FRAME argument can be larger then the
	actual number of frames.


testsuite/ChangeLog

2006-05-05  Vladimir Prus  <ghost@lvk.cs.msu.su>

	* gdb.mi/mi-stack.exp (test_stack_frame_listing): Test that
	HIGH_FRAME argument to -stack-list-locals can be larger than
	the number of frames.


- Volodya