From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10785 invoked by alias); 5 May 2006 18:29:04 -0000 Received: (qmail 10766 invoked by uid 22791); 5 May 2006 18:29:02 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Fri, 05 May 2006 18:28:54 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1Fc52q-0000gi-EX; Fri, 05 May 2006 14:28:52 -0400 Date: Fri, 05 May 2006 18:29:00 -0000 From: Daniel Jacobowitz To: Joel Brobecker Cc: gdb-patches@sources.redhat.com Subject: Re: [RFC/RFA] Cleaner handling of character entities ? Message-ID: <20060505182852.GL31029@nevyn.them.org> Mail-Followup-To: Joel Brobecker , gdb-patches@sources.redhat.com References: <20060505182351.GK1109@adacore.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060505182351.GK1109@adacore.com> User-Agent: Mutt/1.5.8i X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-05/txt/msg00079.txt.bz2 On Fri, May 05, 2006 at 11:23:51AM -0700, Joel Brobecker wrote: > I think the attached patch improves the situation in terms of making > things cleaner in the case of dwarf2, without impacting targets that > still use older debugging format like stabs. > > 2006-05-05 Joel Brobecker > > * dwarf2read.c (read_base_type): Set code to TYPE_CODE_CHAR > for char and unsigned char types. > * ada-lang.c (ada_is_character_type): Always return true if > the type code is TYPE_CODE_CHAR. > * c-valprint.c (c_val_print): Print arrays whose element type > code is TYPE_CODE_CHAR as strings. > > Tested on x86-linux, with GCC 3.4 (dwarf2, stabs+), GCC 4.1 (dwarf2). > No regression. > > What do you guys think? Wouldn't that be a step forward? I really suspect this impacts the existing producers in some way, though I don't know exactly how. You should take a look at the most recent Modula-2 patch, and the discussion around the previous posting of it, which contained very similar changes (conditionalized for M2). -- Daniel Jacobowitz CodeSourcery