Re: [RFC/RFA] Cleaner handling of character entities ?

Daniel Jacobowitz
2006-05-05T19:48:58Z

On Fri, May 05, 2006 at 12:40:02PM -0700, Jim Blandy wrote:
>
> Joel Brobecker <brobecker@adacore.com> writes:
> > We would be left with:
> >
> > * dwarf2read.c (read_base_type): Set code to TYPE_CODE_CHAR
> > for char and unsigned char types of Ada compilation units.
> > * ada-lang.c (ada_is_character_type): Always return true if
> > the type code is TYPE_CODE_CHAR.
> >
> > Would that be OK?
>
> Yeah, I think that sounds like the right thing.

Alternatively, do we think we ought to be using TYPE_CODE_CHAR, and if
so, should we try it?

One possible problem: there are three times as many or so references to
TYPE_CODE_INT in tdep files as there are to TYPE_CODE_CHAR so this
might break argument passing for some targets for C. On those targets
it would probably already be broken for Ada.

--
Daniel Jacobowitz
CodeSourcery