From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20507 invoked by alias); 4 May 2006 05:19:05 -0000 Received: (qmail 20417 invoked by uid 22791); 4 May 2006 05:19:03 -0000 X-Spam-Check-By: sourceware.org Received: from zigzag.lvk.cs.msu.su (HELO zigzag.lvk.cs.msu.su) (158.250.17.23) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 04 May 2006 05:18:53 +0000 Received: from Debian-exim by zigzag.lvk.cs.msu.su with spam-scanned (Exim 4.50) id 1FbWEi-0003Gh-HF for gdb-patches@sources.redhat.com; Thu, 04 May 2006 09:18:50 +0400 Received: from zigzag.lvk.cs.msu.su ([158.250.17.23]) by zigzag.lvk.cs.msu.su with esmtp (Exim 4.50) id 1FbWEX-0003E6-Ea; Thu, 04 May 2006 09:18:37 +0400 From: Vladimir Prus To: "Jim Blandy" Subject: Re: Variable objects: references formatting Date: Thu, 04 May 2006 05:19:00 -0000 User-Agent: KMail/1.7.2 Cc: gdb-patches@sources.redhat.com References: <8f2776cb0605031050q6b9f1b2ale98d0734d4dec3f9@mail.gmail.com> <8f2776cb0605031108j2371fd7dodcc9f6cecf305c5d@mail.gmail.com> In-Reply-To: <8f2776cb0605031108j2371fd7dodcc9f6cecf305c5d@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200605040918.33856.ghost@cs.msu.su> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-05/txt/msg00029.txt.bz2 On Wednesday 03 May 2006 22:08, Jim Blandy wrote: > On 5/3/06, Jim Blandy wrote: > > On 5/3/06, Vladimir Prus wrote: > > > At the moment, when using variable objects to display a struct or a > > > class, the result of -data-evaluate-expression is "...". However, when > > > displaying a reference to a class, the result of > > > -data-evaluate-expression is {}-enclosed list of members and their > > > values. > > > > > > This disparity does not seem to be reasonable, the attached patch fixes > > > it: > > > > I think you're right, and the patch looks good. I'll apply it. > > Some further stuff I came across, for future reference: > > - ChangeLog entries need to have two spaces between the date and the > name, and the name and the email address. Did you know about this rule, will use it in future. > They need an asterisk > before the filename. Check out the other ChangeLog entries for > examples. That's just a typo. > - When declaring a pointer to a type, GNU coding style writes 'type > *ptr', not 'type* ptr'. Oh, sorry, C++ habits. Will try to avoid it. > - In GDB, when traversing types, remember to call check_typedef to > avoid having your traversal stopped by typedef nodes. Thanks, noted. So, in this case I should have called check_typedef before checking if type is reference, right? Would you like me to resend the patch adjusted per your comments, or you've already done those changes locally? Thanks, Volodya