Re: [RFC/RFA/i386] pb reading insns if breakpoints still inserted

Daniel Jacobowitz
2006-04-29T14:28:17Z

On Sat, Apr 29, 2006 at 05:20:42PM +0300, Eli Zaretskii wrote:
> Isn't this a general problem, not limited to x86? That is, if there's
> a breakpoint inserted in the prologue, wouldn't other prologue
> analyzers be fooled?
>
> If this is indeed a general problem, I suggest we fix it in a general
> fashion, not for some specific platform.

That's why many prologue analyzers already use the memory reading
functions which ignore breakpoints; this just improves our consistency.

Now, you could make a reasonable argument that the default when reading
memory ought to be to ignore breakpoints. But that would be a much
harder change to test; we'd need to catch all the places which do need
to see breakpoints - I can only think of one off the top of my head,
but I'm sure there are more. So, I would suggest making it separately.

--
Daniel Jacobowitz
CodeSourcery