From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17440 invoked by alias); 27 Apr 2006 00:42:25 -0000 Received: (qmail 17430 invoked by uid 22791); 27 Apr 2006 00:42:25 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Thu, 27 Apr 2006 00:42:23 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1FYuaL-0003Fw-Fe; Wed, 26 Apr 2006 20:42:21 -0400 Date: Thu, 27 Apr 2006 00:42:00 -0000 From: Daniel Jacobowitz To: Michael Snyder Cc: gdb-patches@sourceware.org Subject: Re: [RFC] problem fetching inferior memory due to breakpoint Message-ID: <20060427004221.GA12481@nevyn.them.org> Mail-Followup-To: Michael Snyder , gdb-patches@sourceware.org References: <20060426190517.GA930@adacore.com> <20060426191946.GA28844@nevyn.them.org> <20060426211817.GB930@adacore.com> <20060426213923.GA6253@nevyn.them.org> <20060426221801.GC930@adacore.com> <20060426222904.GA9745@nevyn.them.org> <44500338.4090808@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <44500338.4090808@redhat.com> User-Agent: Mutt/1.5.8i X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-04/txt/msg00353.txt.bz2 On Wed, Apr 26, 2006 at 04:33:12PM -0700, Michael Snyder wrote: > You know what might be a good optimization? > > Take "breakpoints_inserted" out of infcmd, stick it in breakpoint.c, > and export an access method. It makes no sense for anybody except > breakpoint.c to be keeping track of this anyway. > > Then, read_memory_no_bpt can simply check this, and if it's not set, > default to target_read_memory. True - but not in the big picture. If there's enough breakpoints that walking the linked list checking ->inserted is a problem, think how much more of a problem removing them and inserting them every step time must be. The nice thing about keeping it private in infrun.c is no one else will use it... I don't think we're going to be able to keep being so cavalier with removing and reinserting breakpoints. -- Daniel Jacobowitz CodeSourcery