From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3497 invoked by alias); 26 Apr 2006 21:39:28 -0000 Received: (qmail 3487 invoked by uid 22791); 26 Apr 2006 21:39:27 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Wed, 26 Apr 2006 21:39:25 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1FYrjH-0001dr-Fd for gdb-patches@sourceware.org; Wed, 26 Apr 2006 17:39:23 -0400 Date: Wed, 26 Apr 2006 21:39:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sourceware.org Subject: Re: [RFC] problem fetching inferior memory due to breakpoint Message-ID: <20060426213923.GA6253@nevyn.them.org> Mail-Followup-To: gdb-patches@sourceware.org References: <20060426190517.GA930@adacore.com> <20060426191946.GA28844@nevyn.them.org> <20060426211817.GB930@adacore.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060426211817.GB930@adacore.com> User-Agent: Mutt/1.5.8i X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-04/txt/msg00348.txt.bz2 On Wed, Apr 26, 2006 at 02:18:17PM -0700, Joel Brobecker wrote: > > Try safe_frame_unwind_memory, the other caller of > > deprecated_read_memory_nobpt. Many other prologue analyzers already > > seem to use that. > > Humpf, I must have been sleeping when I did my grep for this function > as I should have seen that too. > > Do you think I should modify win32-nat to use that function or should > I modify read_memory() to use safe_frame_unwind_memory(). I prefer > the latter, because we also protect other platforms where this may > happen too. Neither, where in win32-nat were you planning to modify? Presumably you should change the i386 prologue analyzer. -- Daniel Jacobowitz CodeSourcery