From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12069 invoked by alias); 20 Apr 2006 19:52:00 -0000 Received: (qmail 12055 invoked by uid 22791); 20 Apr 2006 19:51:59 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Thu, 20 Apr 2006 19:51:58 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1FWfBy-000616-Ex; Thu, 20 Apr 2006 15:51:54 -0400 Date: Thu, 20 Apr 2006 19:52:00 -0000 From: Daniel Jacobowitz To: Michael Snyder Cc: Eli Zaretskii , gdb-patches@sources.redhat.com Subject: Re: [RFA] Reverse debugging, part 2/3: core interface Message-ID: <20060420195154.GB22563@nevyn.them.org> Mail-Followup-To: Michael Snyder , Eli Zaretskii , gdb-patches@sources.redhat.com References: <442DAA95.6050708@redhat.com> <444427CA.5060108@redhat.com> <20060420160012.GE11710@nevyn.them.org> <4447E5B2.1080601@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4447E5B2.1080601@redhat.com> User-Agent: Mutt/1.5.8i X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-04/txt/msg00296.txt.bz2 On Thu, Apr 20, 2006 at 12:49:06PM -0700, Michael Snyder wrote: > Good catch. It should probably be get_frame_pc. > You agree? Yep. > >>+ { > >>+ /* Set breakpoint and continue. */ > >>+ breakpoint = > >>+ set_momentary_breakpoint (sal, > >>+ get_frame_id (get_selected_frame (NULL)), > >>+ bp_breakpoint); > > > >...above you used get_current_frame, here you used get_selected_frame. > >Which is it? I think that it should be the selected frame in all three > >cases, by analogy with finish, and there should probably be a similar > >error for cases without a caller. > > Oh man, you're making my head hurt. Which is, I suppose, a good thing. Only fair, you made my brain ache this morning. > What's the difference, now? Is 'current_frame' the execution frame, > and 'selected_frame' the displayed one? (ie. the "up/down" one?) > > If that's the case, then I think you're right, it should be > the selected frame. That's right. -- Daniel Jacobowitz CodeSourcery