From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21584 invoked by alias); 20 Apr 2006 19:10:19 -0000 Received: (qmail 21576 invoked by uid 22791); 20 Apr 2006 19:10:19 -0000 X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (82.92.89.47) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 20 Apr 2006 19:10:16 +0000 Received: from elgar.sibelius.xs4all.nl (root@elgar.sibelius.xs4all.nl [192.168.0.2]) by sibelius.xs4all.nl (8.13.4/8.13.4) with ESMTP id k3KJ9Qmv018408; Thu, 20 Apr 2006 21:09:26 +0200 (CEST) Received: from elgar.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) by elgar.sibelius.xs4all.nl (8.13.6/8.13.6) with ESMTP id k3KJ9QpV016139; Thu, 20 Apr 2006 21:09:26 +0200 (CEST) Received: (from kettenis@localhost) by elgar.sibelius.xs4all.nl (8.13.6/8.13.6/Submit) id k3KJ9QFw030373; Thu, 20 Apr 2006 21:09:26 +0200 (CEST) Date: Thu, 20 Apr 2006 19:10:00 -0000 Message-Id: <200604201909.k3KJ9QFw030373@elgar.sibelius.xs4all.nl> From: Mark Kettenis To: drow@false.org CC: mark.kettenis@xs4all.nl, jimb@red-bean.com, msnyder@redhat.com, gdb-patches@sourceware.org In-reply-to: <20060420172112.GK11710@nevyn.them.org> (message from Daniel Jacobowitz on Thu, 20 Apr 2006 13:21:12 -0400) Subject: Re: [RFA/RFC] dwarf2-frame read_reg References: <443C7529.7020206@redhat.com> <8f2776cb0604112142i32dcdf0dic8f44f2989311786@mail.gmail.com> <200604121817.k3CIH7nA021495@elgar.sibelius.xs4all.nl> <20060420172112.GK11710@nevyn.them.org> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-04/txt/msg00291.txt.bz2 > X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on > elgar.sibelius.xs4all.nl > X-Spam-Level: > X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=failed > version=3.1.0 > Date: Thu, 20 Apr 2006 13:21:12 -0400 > From: Daniel Jacobowitz > Cc: jimb@red-bean.com, msnyder@redhat.com, gdb-patches@sourceware.org > Mail-Followup-To: Mark Kettenis , jimb@red-bean.com, msnyder@redhat.com, gdb-patches@sourceware.org > Content-Disposition: inline > X-IsSubscribed: yes > Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm > Sender: gdb-patches-owner@sourceware.org > X-UTwente-MailScanner-Information: Scanned by MailScanner. Contact helpdesk@ITBE.utwente.nl for more information. > X-UTwente-MailScanner: Found to be clean > X-MailScanner-From: gdb-patches-return-43755-m.m.kettenis=alumnus.utwente.nl@sourceware.org > X-XS4ALL-DNSBL-Checked: mxdrop5.xs4all.nl checked 192.87.17.19 against DNS blacklists > X-Virus-Scanned: by XS4ALL Virus Scanner > X-XS4ALL-Spam-Score: 0 () > X-XS4ALL-Spam: NO > Envelope-To: mark.kettenis@xs4all.nl > X-UIDL: 1145553701._smtp.mxdrop5.43414,S=4323 > > On Wed, Apr 12, 2006 at 08:17:07PM +0200, Mark Kettenis wrote: > > > Date: Tue, 11 Apr 2006 21:42:01 -0700 > > > From: "Jim Blandy" > > > > > > On 4/11/06, Michael Snyder wrote: > > > > I want you guys to vett this change. I was getting wrong results > > > > on a target where sizeof (SP) != sizeof (void *). The local func > > > > read_reg was calling extract_unsigned_integer with the wrong size. > > > > > > Well, extract_typed_address requires the type of the register to be > > > some sort of pointer. read_reg is given as a callback to the Dwarf > > > expression evaluator in dwarf2expr.c, so it could be handed any > > > register at all. > > > > > > How about unpack_long (buf, register_type (gdbarch, regnum))? > > > Definitely regression-test this on several platforms... > > > > This is likely to be wrong for platforms where addresses are signed. > > It shouldn't be. Ok, cool. Objection withdrawn. Mark