From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18893 invoked by alias); 20 Apr 2006 16:27:36 -0000 Received: (qmail 18876 invoked by uid 22791); 20 Apr 2006 16:27:36 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Thu, 20 Apr 2006 16:27:34 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1FWc08-0004fi-Qm; Thu, 20 Apr 2006 12:27:29 -0400 Date: Thu, 20 Apr 2006 16:27:00 -0000 From: Daniel Jacobowitz To: Frederic RISS Cc: Jim Blandy , GDB Patches Subject: Re: [RFC] Don't lose compilation directory in Dwarf2 line-tables Message-ID: <20060420162728.GG11710@nevyn.them.org> Mail-Followup-To: Frederic RISS , Jim Blandy , GDB Patches References: <1144927446.14807.561.camel@crx549.cro.st.com> <8f2776cb0604131049i69e9b20fv78e60c023f245e56@mail.gmail.com> <1144999942.14807.721.camel@crx549.cro.st.com> <8f2776cb0604140041o63c56c2xa9113d3c4ee259d@mail.gmail.com> <1145002976.14807.744.camel@crx549.cro.st.com> <20060414140449.GA14270@nevyn.them.org> <1145026289.14807.816.camel@crx549.cro.st.com> <1145363529.14807.848.camel@crx549.cro.st.com> <20060418130432.GC10130@nevyn.them.org> <1145368299.14807.889.camel@crx549.cro.st.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1145368299.14807.889.camel@crx549.cro.st.com> User-Agent: Mutt/1.5.8i X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-04/txt/msg00278.txt.bz2 On Tue, Apr 18, 2006 at 03:51:39PM +0200, Frederic RISS wrote: > + if (dirname != NULL && dir != dirname) > + xfree(dir); xfree (dir) :-) I've got no concerns about this patch; Jim was looking at this more than I was, though, so I hope he'll take a moment to look at this version. -- Daniel Jacobowitz CodeSourcery