Re: D Symbol Demangling

[Daniel Jacobowitz <drow@false.org>]

On Wed, Apr 19, 2006 at 02:17:04PM +0200, Thomas Kuehne wrote:
> Attached is a patch against GDB-6.4 that enables demangling of symbols
> generated by DMD[1] and GDC[2].
> 
> The infrastructure part (c-lang.c, defs.h, d-lang.h, dwarf2read.c,
> language.c, Makefile.in, symfile, syntab.c, dwarf2.h) is based on John
> Demme's work[3][4].
> 
> The pluggable demangler (gdb/demangle_d/*) was written completely form
> scratch and isn't based on John's work and supports templates and - to a
> certain extend - nested functions and types.

Unfortunately, there are several major problems with accepting this
code.

1.  Neither you nor John has an FSF copyright assignment in place.  If
you're interested in one, let me know and I can send you the forms.

2.  The demangler would need to be contributed to the FSF and licensed
under the GPL before we could include it with GDB.  That doesn't
prevent another copy of it from being used under a different license
elsewhere; but you wouldn't be able to import fixes from one to the
other, in either direction.

3.  The code would need to match the GNU Coding Standards.

4.  A patch would need to be generated against HEAD, not against an old
release.

And, no offense, but the DD_() thing is horribly ugly and doesn't seem
to serve any purpose here.  Is that for reusing the demangler
elsewhere?

-- 
Daniel Jacobowitz
CodeSourcery