From: Daniel Jacobowitz <drow@false.org>
To: Randolph Chung <randolph@tausq.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [rfa] Shared object matching for solib-som.c
Date: Wed, 19 Apr 2006 12:33:00 -0000 [thread overview]
Message-ID: <20060419123331.GA9052@nevyn.them.org> (raw)
In-Reply-To: <44458D3D.4030506@tausq.org>
On Wed, Apr 19, 2006 at 09:07:09AM +0800, Randolph Chung wrote:
> I notice that most of the solib variants do not need to do this type of
> processing; unfortunately I haven't figured out a better way to handle
> the SOM case. Perhaps somebody more familiar with the solib code/SOM can
> comment?
No one else needs to do this, in fact. This is from the symfile
section_offsets callback; but why can't you do this in the
solib relocate_section_addresses callback instead? In fact, you
already do, so it is not at all clear to me why you need to adjust the
offsets here. Other targets only need to adjust the one copy in the
section table.
Ah, I think this normally works via
build_section_addr_info_from_section_table. Which produces the second
parameter for som_symfile_offsets. Which is now valid for shared
libraries. It's just that the way that function _uses_ it is bogus for
shared libraries. Instead of finding the .text offset you'd have to
honor the section indexes. See default_symfile_offsets.
Also the two solib-som.c functions setting offsets use different data
offsets, so beware that.
--
Daniel Jacobowitz
CodeSourcery
prev parent reply other threads:[~2006-04-19 12:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-19 1:07 Randolph Chung
2006-04-19 8:15 ` Eli Zaretskii
2006-04-19 8:29 ` Randolph Chung
2006-04-19 9:07 ` Eli Zaretskii
2006-04-19 12:33 ` Daniel Jacobowitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060419123331.GA9052@nevyn.them.org \
--to=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
--cc=randolph@tausq.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox