From: Daniel Jacobowitz <drow@false.org>
To: Michael Snyder <msnyder@redhat.com>,
GDB Patches <gdb-patches@sources.redhat.com>
Subject: Re: [RFA] Reverse debugging, part 1/3: target interface
Date: Tue, 18 Apr 2006 15:24:00 -0000 [thread overview]
Message-ID: <20060418152443.GA13825@nevyn.them.org> (raw)
In-Reply-To: <20060418125836.GB10130@nevyn.them.org>
On Tue, Apr 18, 2006 at 08:58:36AM -0400, Daniel Jacobowitz wrote:
> On Mon, Apr 17, 2006 at 04:37:43PM -0700, Michael Snyder wrote:
> > Two week ping... there having been no objections to this patch,
> > shall I check it in?
>
> For something this major, I think we should make sure someone else at
> least looks over it first. I haven't had time, and I was hoping that
> someone else would take the time; but if no one does, I will
> definitely get to it soon.
Oh, I see one thing in a first look: you are adding to the remote
protocol without adding documentation for the new packets or error
codes. Please document them!
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2006-04-18 15:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <442DAA70.5070203@redhat.com>
2006-04-01 12:23 ` Eli Zaretskii
2006-04-17 23:37 ` Michael Snyder
2006-04-18 12:58 ` Daniel Jacobowitz
2006-04-18 15:24 ` Daniel Jacobowitz [this message]
2006-04-18 22:08 ` Michael Snyder
2006-04-19 8:48 ` Eli Zaretskii
2006-04-19 18:26 ` Michael Snyder
2006-04-20 9:18 ` Eli Zaretskii
2006-04-20 13:43 ` Daniel Jacobowitz
2006-04-20 19:22 ` Michael Snyder
2006-04-20 19:50 ` Daniel Jacobowitz
2006-04-20 23:53 ` Michael Snyder
2006-04-24 20:55 ` Daniel Jacobowitz
2006-04-18 18:59 ` Michael Snyder
2006-04-20 13:58 ` Daniel Jacobowitz
2006-04-20 19:42 ` Michael Snyder
2006-04-20 19:58 ` Daniel Jacobowitz
2006-04-01 16:39 Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060418152443.GA13825@nevyn.them.org \
--to=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
--cc=msnyder@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox