From: Daniel Jacobowitz <drow@false.org>
To: DJ Delorie <dj@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [v850 sim] correcting psw flags for divide special cases.
Date: Fri, 14 Apr 2006 20:36:00 -0000 [thread overview]
Message-ID: <20060414203613.GA23889@nevyn.them.org> (raw)
In-Reply-To: <20060414203520.GA23815@nevyn.them.org>
On Fri, Apr 14, 2006 at 04:35:20PM -0400, Daniel Jacobowitz wrote:
> On Thu, Apr 13, 2006 at 07:36:49PM -0400, DJ Delorie wrote:
> >
> > 2006-04-13 DJ Delorie <dj@redhat.com>
> >
> > * simops.c (OP_2C207E0): Correct PSW flags for special divu
> > conditions.
> > (OP_2C007E0): Likewise, for div.
> > (OP_28207E0): Likewise, for divhu.
> > (OP_28007E0): Likewise, for divh.
>
> Hi DJ,
>
> The problem with patches without any human-readable text is we don't
> know what you expect of them... are you asking for approval? If so,
> I'm not sure why, since you're the m32c sim maintainer and few others
> on this list even know what an m32c is. If you're just posting the
> patch as an "FYI, I committed this", then I'd like to point out that
> you didn't commit it :-)
Er, this was a v850 patch, not an m32c patch. D'oh.
Is there anyone out there who can review v850 changes? If not, I
don't see any reason why you shouldn't check them in.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2006-04-14 20:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-13 23:37 DJ Delorie
2006-04-14 20:35 ` Daniel Jacobowitz
2006-04-14 20:36 ` Daniel Jacobowitz [this message]
2006-04-17 19:35 ` DJ Delorie
2006-04-17 19:49 ` Daniel Jacobowitz
2006-04-17 20:20 ` DJ Delorie
2006-04-18 19:25 ` Daniel Jacobowitz
2006-04-18 19:36 ` DJ Delorie
2006-04-20 13:09 ` Daniel Jacobowitz
2006-05-04 15:40 ` Daniel Jacobowitz
2006-04-18 19:44 ` [v850 sim] REVISED " DJ Delorie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060414203613.GA23889@nevyn.them.org \
--to=drow@false.org \
--cc=dj@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox