From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18601 invoked by alias); 13 Apr 2006 04:05:46 -0000 Received: (qmail 18593 invoked by uid 22791); 13 Apr 2006 04:05:44 -0000 X-Spam-Check-By: sourceware.org Received: from dsl027-180-168.sfo1.dsl.speakeasy.net (HELO sunset.davemloft.net) (216.27.180.168) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 13 Apr 2006 04:05:40 +0000 Received: from localhost ([127.0.0.1] ident=davem) by sunset.davemloft.net with esmtp (Exim 4.60) (envelope-from ) id 1FTt5W-0001Ux-HM; Wed, 12 Apr 2006 21:05:46 -0700 Date: Thu, 13 Apr 2006 04:05:00 -0000 Message-Id: <20060412.210543.123363581.davem@davemloft.net> To: msnyder@redhat.com Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH]: Don't use deprecated regcache functions From: "David S. Miller" In-Reply-To: <443DBA66.6050409@redhat.com> References: <443D540D.2050902@redhat.com> <20060412.180948.72680402.davem@davemloft.net> <443DBA66.6050409@redhat.com> X-Mailer: Mew version 4.2.53 on Emacs 21.4 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-04/txt/msg00162.txt.bz2 From: Michael Snyder Date: Wed, 12 Apr 2006 19:41:42 -0700 > I get confused just thinking about all these variants. > If you have an argument for why one is more correct in > this context, I'm certainly open to it. I can't really > convince myself that the current behavior is correct, > since deprecated_read_register_gen calls regcache_cooked_read, > which may call regcache_raw_read, which may call > target_fetch_registers *before* capturing the current value. > Which it seems like would defeat the purpose of the whole > exercise... Any of these arguments for or against apply to the Solaris thread code which does use regcache_raw_read() in this same exact situation.