From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29197 invoked by alias); 11 Apr 2006 20:00:20 -0000 Received: (qmail 29188 invoked by uid 22791); 11 Apr 2006 20:00:19 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Tue, 11 Apr 2006 20:00:16 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1FTP21-0000rX-DV; Tue, 11 Apr 2006 16:00:09 -0400 Date: Tue, 11 Apr 2006 20:00:00 -0000 From: Daniel Jacobowitz To: Mark Mitchell , gdb-patches@sources.redhat.com Subject: Re: PATCH: Disable ARM RDP Message-ID: <20060411200009.GA3235@nevyn.them.org> Mail-Followup-To: Mark Mitchell , gdb-patches@sources.redhat.com References: <200603172225.k2HMPgPG024087@sethra.codesourcery.com> <20060324203053.GC26748@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060324203053.GC26748@nevyn.them.org> User-Agent: Mutt/1.5.8i X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-04/txt/msg00135.txt.bz2 On Fri, Mar 24, 2006 at 03:30:53PM -0500, Daniel Jacobowitz wrote: > On Fri, Mar 17, 2006 at 02:25:42PM -0800, Mark Mitchell wrote: > > > > This patch removes remote-rdp.o from ARM's TDEPFILES since Daniel and > > Paul say that it's useless to most people. I also found that with > > --disable-sim GDB fails to link because remote-rdp.c references a > > function defined in the simulator. > > > > I'm not sure if this is the right patch for mainline, or whether > > people would rather I remove remote-rdp.c entirely, or do nothing, or > > ... So, I guess this is a request for approval, but a pretty > > tentative one. > > > * gdb/config/arm/embed.mt (TDEPFILES): Remove remote-rdp.o. > > Well, this patch isn't OK. Afterwards remote-rdp is orphaned - no > other configuration uses it. So, either we are removing it, or we > aren't. > > I'm in favor of removing it. Strikes against it: > > - It doesn't build with --disable-sim. > - It doesn't build on some versions of MinGW32, because it > references sleep(). > - It's an old remote protocol and I haven't seen any reports of > it being used. > - Using RDP directly is even older than using RDI to talk to > the same devices, which we've already removed. > > I have no real preference on removing it immediately versus marking it > obsolete in the next release; the first two bullets are problems for > CodeSourcery, but we can always turn it off in our release branch. > But I'd like to do one or the other. Anyone have a preference? I didn't see any comments on this. I'm pretty confident that no one uses this protocol any more, so I would like to remove it, unless anyone objects. So, please speak up, if you object to "target rdp" being removed from the arm-elf target. No other triplet enables it. (I had to apply a global interface change to remote-rdp.c today, which reminded me. Many of these remote targets I'm patching deserve to be removed. Let's make sure to get a complete list before the next release...) -- Daniel Jacobowitz CodeSourcery