From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17455 invoked by alias); 11 Apr 2006 22:32:39 -0000 Received: (qmail 17447 invoked by uid 22791); 11 Apr 2006 22:32:38 -0000 X-Spam-Check-By: sourceware.org Received: from dsl027-180-168.sfo1.dsl.speakeasy.net (HELO sunset.davemloft.net) (216.27.180.168) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 11 Apr 2006 22:32:36 +0000 Received: from localhost ([127.0.0.1] ident=davem) by sunset.davemloft.net with esmtp (Exim 4.60) (envelope-from ) id 1FTRPO-0008WE-BN; Tue, 11 Apr 2006 15:32:26 -0700 Date: Tue, 11 Apr 2006 22:32:00 -0000 Message-Id: <20060411.153222.40565227.davem@davemloft.net> To: drow@false.org Cc: mark.kettenis@xs4all.nl, gdb-patches@sourceware.org Subject: Re: Save the length of inserted breakpoints From: "David S. Miller" In-Reply-To: <20060411214613.GA702@nevyn.them.org> References: <20060302221711.GB18830@nevyn.them.org> <200603022301.k22N1qEt008208@elgar.sibelius.xs4all.nl> <20060411214613.GA702@nevyn.them.org> X-Mailer: Mew version 4.2.53 on Emacs 21.4 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-04/txt/msg00140.txt.bz2 From: Daniel Jacobowitz Date: Tue, 11 Apr 2006 17:46:13 -0400 > All true. Do you like this version better? I think it's much > more elegant. target_insert_breakpoint et al. now take the > struct bp_location, instead of just the shadow contents cache. > They can fill in whatever they choose. > > I added some helper functions for the other common breakpoint > activities while I was there. This should consolidate all the actual > inserting and removing of breakpoints within breakpoint.c, and > allow future cleanups. I've regression tested this on sparc-*-linux-gnu, no new failures.