From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11717 invoked by alias); 10 Apr 2006 03:31:49 -0000 Received: (qmail 11709 invoked by uid 22791); 10 Apr 2006 03:31:49 -0000 X-Spam-Check-By: sourceware.org Received: from dsl027-180-168.sfo1.dsl.speakeasy.net (HELO sunset.davemloft.net) (216.27.180.168) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 10 Apr 2006 03:31:47 +0000 Received: from localhost ([127.0.0.1] ident=davem) by sunset.davemloft.net with esmtp (Exim 4.60) (envelope-from ) id 1FSn7u-0007Rc-FA; Sun, 09 Apr 2006 20:31:42 -0700 Date: Mon, 10 Apr 2006 03:31:00 -0000 Message-Id: <20060409.203142.76326217.davem@davemloft.net> To: nickrob@snap.net.nz Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH]: Fix gdb.mi/mi-regs.exp From: "David S. Miller" In-Reply-To: <17465.33321.414493.769813@farnswood.snap.net.nz> References: <17465.33321.414493.769813@farnswood.snap.net.nz> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-04/txt/msg00114.txt.bz2 From: Nick Roberts Date: Mon, 10 Apr 2006 09:52:41 +1200 > > > 2006-04-08 David S. Miller > > > * gdb.mi/mi-regs.exp (111-data-list-register-values x): "No registers" > > will get printed without a mi_cmd_data_list_register_values prefix. > > (*-data-list-register-*): Correct regular expressions to expect the new > > pseudo d? floating point registers. > > Do you need to apply these changes to mi2-regs.exp also? Yes. > Should there be similar tests for other architectures? If they are only > intended for sparc, shouldn't this file be called mi-sparc-regs.exp? There are "XXX" style comments in there suggesting that strings for other platforms should be added. It is a similar situation to gdb.base/float.exp, knowledgable people just have to get around to adding the per-target strings.