Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: davem@davemloft.net
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH]: Get dwarf2 working on sparc64 too.
Date: Sat, 08 Apr 2006 21:01:00 -0000	[thread overview]
Message-ID: <200604082100.k38L0LF3010368@elgar.sibelius.xs4all.nl> (raw)
In-Reply-To: <20060405.171555.27430870.davem@davemloft.net>

> Date: Wed, 05 Apr 2006 17:15:55 -0700 (PDT)
> From: "David S. Miller" <davem@davemloft.net>
> 
> There were two problems:
> 
> 1) The sparc32 registry of the dwarf2 reg_init function has
>    to occur before osabi init, so that osabi can override
>    properly.

Duh, yes.

> 2) We have to mark the global registers as explicitly undefined.
>    Besides, they are call clobbered.
> 
>    This handles the case where gcc emits a DW_CFA_GNU_window_save,
>    which causes the gdb dwarf2 frame code to allocate a reg set out
>    to 32 registers, but it only sets up entries 8 --> 16.  We get ugly
>    warnings.

This looks wrong to me.  For one thing %g2, %g3, %g6 and %g7 are *not*
call clobbered according to SCD 2.4.1.  And I fail to see why
DW_CFA_GNU_window_save has anything to do with the global registers,
since window saves only affect the other 24 general purpose registers.

What are the ugly warnings that you're trying to fix?

> 2006-04-05  David S. Miller  <davem@sunset.davemloft.net>
> 
> 	* sparc64-linux-tdep.c (sparc64_linux_init_abi): Append dwarf2
> 	frame sniffer.
> 	* sparc-tdep.c (sparc32_gdbarch_init): Make sure to call
> 	dwarf2_frame_set_init_reg() before gdbarch_init_osabi() so
> 	that the latter can override.
> 	(sparc32_dwarf2_frame_init_reg): Mark global registers as
> 	undefined.
> 	* sparc64-tdep.c (sparc64_dwarf2_frame_init_reg): Likewise.
> 	* Makefile.in (sparc64-linux-tdep.o): Update dependencies.


  reply	other threads:[~2006-04-08 21:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-06  0:16 David S. Miller
2006-04-08 21:01 ` Mark Kettenis [this message]
2006-04-08 22:16   ` David S. Miller
2006-04-08 23:03     ` David S. Miller
2006-04-09  7:17       ` Mark Kettenis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200604082100.k38L0LF3010368@elgar.sibelius.xs4all.nl \
    --to=mark.kettenis@xs4all.nl \
    --cc=davem@davemloft.net \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox