From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17325 invoked by alias); 8 Apr 2006 23:03:50 -0000 Received: (qmail 17310 invoked by uid 22791); 8 Apr 2006 23:03:48 -0000 X-Spam-Check-By: sourceware.org Received: from dsl027-180-168.sfo1.dsl.speakeasy.net (HELO sunset.davemloft.net) (216.27.180.168) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 08 Apr 2006 23:03:45 +0000 Received: from localhost ([127.0.0.1] ident=davem) by sunset.davemloft.net with esmtp (Exim 4.60) (envelope-from ) id 1FSMT0-0007RB-MX; Sat, 08 Apr 2006 16:03:42 -0700 Date: Sat, 08 Apr 2006 23:03:00 -0000 Message-Id: <20060408.160342.53614785.davem@davemloft.net> To: mark.kettenis@xs4all.nl Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH]: Get dwarf2 working on sparc64 too. From: "David S. Miller" In-Reply-To: <20060408.151611.43979592.davem@davemloft.net> References: <20060405.171555.27430870.davem@davemloft.net> <200604082100.k38L0LF3010368@elgar.sibelius.xs4all.nl> <20060408.151611.43979592.davem@davemloft.net> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-04/txt/msg00104.txt.bz2 From: "David S. Miller" Date: Sat, 08 Apr 2006 15:16:11 -0700 (PDT) Actually... > The one generated here in dwarf2-frame.c:dwarf2_frame_cache(): > > if (fs->regs.reg[column].how == DWARF2_FRAME_REG_UNSPECIFIED) > { > if (cache->reg[regnum].how == DWARF2_FRAME_REG_UNSPECIFIED) > complaint (&symfile_complaints, _("\ > incomplete CFI data; unspecified registers (e.g., %s) at 0x%s"), > gdbarch_register_name (gdbarch, regnum), > paddr_nz (fs->pc)); > } > > It will be generated for every global register (other than %g0 which > we already explicitly mark on Sparc) without my change. I went back and I'm having trouble reproducing this issue right now. Really strange. So let's just do the obvious stuff since the testsuite works fine and doesn't generate the warnings anymore on Sparc/Linux with the following patch. Ok to apply? We can investigate the global register stuff later if it pops up again. Thanks a bunch for your reviewing efforts Mark. 2006-04-08 David S. Miller * sparc64-linux-tdep.c (sparc64_linux_init_abi): Append dwarf2 frame sniffer. * sparc-tdep.c (sparc32_gdbarch_init): Make sure to call dwarf2_frame_set_init_reg() before gdbarch_init_osabi() so that the latter can override. * Makefile.in (sparc64-linux-tdep.o): Update dependencies. Index: sparc-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/sparc-tdep.c,v retrieving revision 1.170 diff -u -p -r1.170 sparc-tdep.c --- sparc-tdep.c 5 Apr 2006 20:01:19 -0000 1.170 +++ sparc-tdep.c 8 Apr 2006 22:57:48 -0000 @@ -1296,14 +1296,14 @@ sparc32_gdbarch_init (struct gdbarch_inf frame_base_set_default (gdbarch, &sparc32_frame_base); - /* Hook in ABI-specific overrides, if they have been registered. */ - gdbarch_init_osabi (info, gdbarch); - /* Hook in the DWARF CFI frame unwinder. */ dwarf2_frame_set_init_reg (gdbarch, sparc32_dwarf2_frame_init_reg); /* FIXME: kettenis/20050423: Don't enable the unwinder until the StackGhost issues have been resolved. */ + /* Hook in ABI-specific overrides, if they have been registered. */ + gdbarch_init_osabi (info, gdbarch); + frame_unwind_append_sniffer (gdbarch, sparc32_frame_sniffer); /* If we have register sets, enable the generic core file support. */ Index: sparc64-linux-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/sparc64-linux-tdep.c,v retrieving revision 1.13 diff -u -p -r1.13 sparc64-linux-tdep.c --- sparc64-linux-tdep.c 8 Apr 2006 21:15:26 -0000 1.13 +++ sparc64-linux-tdep.c 8 Apr 2006 22:57:48 -0000 @@ -22,6 +22,7 @@ #include "defs.h" #include "frame.h" #include "frame-unwind.h" +#include "dwarf2-frame.h" #include "regset.h" #include "regcache.h" #include "gdbarch.h" @@ -195,6 +196,9 @@ sparc64_linux_init_abi (struct gdbarch_i tramp_frame_prepend_unwinder (gdbarch, &sparc64_linux_rt_sigframe); + /* Hook in the DWARF CFI frame unwinder. */ + frame_unwind_append_sniffer (gdbarch, dwarf2_frame_sniffer); + sparc64_init_abi (info, gdbarch); /* GNU/Linux has SVR4-style shared libraries... */ Index: Makefile.in =================================================================== RCS file: /cvs/src/src/gdb/Makefile.in,v retrieving revision 1.806 diff -u -p -r1.806 Makefile.in --- Makefile.in 8 Apr 2006 21:15:26 -0000 1.806 +++ Makefile.in 8 Apr 2006 23:01:13 -0000 @@ -2616,9 +2616,9 @@ sparc64-linux-nat.o: sparc64-linux-nat.c $(gregset_h) $(sparc64_tdep_h) $(sparc_tdep_h) \ $(sparc_nat_h) $(inferior_h) $(target_h) $(linux_nat_h) sparc64-linux-tdep.o: sparc64-linux-tdep.c $(defs_h) $(frame_h) \ - $(frame_unwind_h) $(regset_h) $(regcache_h) $(gdbarch_h) \ - $(gdbcore_h) $(osabi_h) $(solib_svr4_h) $(symtab_h) $(trad_frame_h) \ - $(tramp_frame_h) $(sparc64_tdep_h) + $(frame_unwind_h) $(dwarf2-frame_h) $(regset_h) $(regcache_h) \ + $(gdbarch_h) $(gdbcore_h) $(osabi_h) $(solib_svr4_h) $(symtab_h) \ + $(trad_frame_h) $(tramp_frame_h) $(sparc64_tdep_h) sparc64-nat.o: sparc64-nat.c $(defs_h) $(gdbarch_h) $(sparc64_tdep_h) \ $(sparc_nat_h) sparc64nbsd-nat.o: sparc64nbsd-nat.c $(defs_h) $(regcache_h) $(target_h) \