From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5849 invoked by alias); 8 Apr 2006 21:03:11 -0000 Received: (qmail 5840 invoked by uid 22791); 8 Apr 2006 21:03:10 -0000 X-Spam-Check-By: sourceware.org Received: from dsl027-180-168.sfo1.dsl.speakeasy.net (HELO sunset.davemloft.net) (216.27.180.168) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 08 Apr 2006 21:03:05 +0000 Received: from localhost ([127.0.0.1] ident=davem) by sunset.davemloft.net with esmtp (Exim 4.60) (envelope-from ) id 1FSKaD-00070a-HK; Sat, 08 Apr 2006 14:03:01 -0700 Date: Sat, 08 Apr 2006 21:03:00 -0000 Message-Id: <20060408.140301.18104759.davem@davemloft.net> To: drow@false.org Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH]: Fix signal handler stepping on Linux/Sparc From: "David S. Miller" In-Reply-To: <20060408202900.GA18707@nevyn.them.org> References: <20060407.231843.63374146.davem@davemloft.net> <20060408202900.GA18707@nevyn.them.org> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-04/txt/msg00100.txt.bz2 From: Daniel Jacobowitz Date: Sat, 8 Apr 2006 16:29:00 -0400 > On Fri, Apr 07, 2006 at 11:18:43PM -0700, David S. Miller wrote: > > It seems that perhaps some other Linux targets don't handle this right > > too. > > > > MIPS is the most likely platform that gets this wrong in the same > > exact way, as I don't see any handling of system call instructions in > > the software single-step handler which MIPS/Linux uses. > > I know that I have fixed this for MIPS before. I may have not followed > through on the patch, though. ARM has a similar problem. Those two > I'll fix at some point; Alpha I'm probably going to leave for someone > who has more need for the port... Someone like Richard Henderson should be able to cook up a fix for Alpha without much effort, so hopefully someone like him will get around to it at some point. > > 2006-04-07 David S. Miller > > > > * sparc-linux-tdep.c (sparc32_linux_step_trap): New. > > (sparc32_linux_init_abi): Hook it into tdep->step_trap. > > * sparc64-linux-tdep.c (sparc64_linux_step_trap): New. > > (sparc64_linux_init_abi): Hook it into tdep->step_trap. > > * Makefile.in: Update dependencies. > > Yes, this is fine. Thanks. Thanks a lot for reviewing, committed.