From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32249 invoked by alias); 7 Apr 2006 13:16:28 -0000 Received: (qmail 32238 invoked by uid 22791); 7 Apr 2006 13:16:27 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Fri, 07 Apr 2006 13:16:26 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1FRqp5-0005Go-OG; Fri, 07 Apr 2006 09:16:23 -0400 Date: Fri, 07 Apr 2006 13:16:00 -0000 From: Daniel Jacobowitz To: "David S. Miller" Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH]: PTRACE_PEEKUSER redux... Message-ID: <20060407131622.GA20181@nevyn.them.org> Mail-Followup-To: "David S. Miller" , gdb-patches@sources.redhat.com References: <20060406.220357.102230498.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060406.220357.102230498.davem@davemloft.net> User-Agent: Mutt/1.5.8i X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-04/txt/msg00087.txt.bz2 On Thu, Apr 06, 2006 at 10:03:57PM -0700, David S. Miller wrote: > In all cases, no matter what ptrace operation is specified, if the > child does not exist the error return we will get is -ESRCH (task not > found for pid) or -EPERM (trying to trace init or similar). This relies on all platforms doing the permission check before the operation check. Well, I guess it's still better than what we had before, right? > 2006-04-06 David S. Miller > > * linux-nat.c (linux_nat_thread_alive): Thread is alive > as long as errno is neither -ESRCH nor -EPERM. This allows > to handle cleanly the case where PTRACE_PEEKUSER is not > a supported ptrace operation for a given Linux target. OK, except, please reverse the changelog and the patch :-) This comment should be in the source code, or we'll break it again later. -- Daniel Jacobowitz CodeSourcery