From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27059 invoked by alias); 28 Mar 2006 22:40:05 -0000 Received: (qmail 27049 invoked by uid 22791); 28 Mar 2006 22:40:05 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Tue, 28 Mar 2006 22:40:03 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1FOMr1-0003Ip-44; Tue, 28 Mar 2006 17:39:59 -0500 Date: Wed, 29 Mar 2006 00:04:00 -0000 From: Daniel Jacobowitz To: Alexandre Oliva Cc: gdb-patches@sourceware.org Subject: Re: add support for =?iso-8859-1?Q?`S?= =?iso-8859-1?Q?=B4?= augmentation in dwarf2 debug info Message-ID: <20060328223959.GE11817@nevyn.them.org> Mail-Followup-To: Alexandre Oliva , gdb-patches@sourceware.org References: <20060304150719.GD20187@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.8i X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-03/txt/msg00332.txt.bz2 On Tue, Mar 07, 2006 at 02:23:10AM -0300, Alexandre Oliva wrote: > On Mar 4, 2006, Daniel Jacobowitz wrote: > > > On Fri, Mar 03, 2006 at 12:18:43PM -0300, Alexandre Oliva wrote: > >> This patch introduces code to recognize and take advantage of the "S" > >> augmentation, but makes no effort to remove existing machine-specific > >> code. The testcase probably already worked without the change, but > >> it's good to have it there to avoid regressions when someone decides > >> to experiment with taking code out. > > > Is that enough justification for such a nasty testcase? And it's going > > to need more work over time; for instance, old assemblers or libgccs > > will fail to build it, producing a noisy ERROR. > > If the code changes are fine without the testcase, I'll be more than > happy to check them in as such. Are they? Yes, the code changes are OK. Thanks and sorry for the delay. -- Daniel Jacobowitz CodeSourcery