From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15159 invoked by alias); 28 Mar 2006 22:12:53 -0000 Received: (qmail 15151 invoked by uid 22791); 28 Mar 2006 22:12:53 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Tue, 28 Mar 2006 22:12:52 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1FOMQj-000342-D7; Tue, 28 Mar 2006 17:12:49 -0500 Date: Tue, 28 Mar 2006 22:27:00 -0000 From: Daniel Jacobowitz To: Randolph Chung Cc: gdb-patches@sources.redhat.com Subject: Re: [patch] Compile fix for 64-bit HPUX Message-ID: <20060328221249.GD10392@nevyn.them.org> Mail-Followup-To: Randolph Chung , gdb-patches@sources.redhat.com References: <44264D9D.5070305@tausq.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <44264D9D.5070305@tausq.org> User-Agent: Mutt/1.5.8i X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-03/txt/msg00326.txt.bz2 On Sun, Mar 26, 2006 at 04:15:25PM +0800, Randolph Chung wrote: > On 64-bit HPUX, gdb fails to compile with -Werror because of an > incorrect iconv() prototype. gdb's configure script checks for this, but > because the configure script test is compiled without -Werror even when > -Werror is enabled, the test doesn't detect the condition properly. The > attached patch forces this test to use the value of WERROR_CFLAGS so > that the check uses the same flags that will be used to build gdb. > > tbh I think this is really a hack and we should somehow make all the > autoconf test use the -Werror flag when running the compile tests, but > it's not obvious to me how I can do this without redoing a lot of the > Makefile logic (for example, why do we use a separate WERROR_CFLAGS and > not just append the -Werror into CFLAGS?)... So that we can turn off -Werror without turning off warnings, I presume. I thought I'd touched this code recently but I don't see where... Don't most autoconf checks fail if they produce a warning, anyway? Oh, that's got a separate knob: AC_LANG_WERROR. Maybe that would help you. And AC_PROG_CPP_WERROR. I don't know why no one uses AC_LANG_WERROR in src yet; maybe there's a good reason. > + oldcflags="${CFLAGS-}" What's ${foo-}? I don't see it in my bash or dash docs. -- Daniel Jacobowitz CodeSourcery