From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24390 invoked by alias); 27 Mar 2006 19:57:41 -0000 Received: (qmail 24381 invoked by uid 22791); 27 Mar 2006 19:57:41 -0000 X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 27 Mar 2006 19:57:39 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id k2RJvcnD025358 for ; Mon, 27 Mar 2006 14:57:38 -0500 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.12.11.20060308/8.11.6) with ESMTP id k2RJvWIq024240 for ; Mon, 27 Mar 2006 14:57:32 -0500 Received: from localhost.localdomain (vpn50-73.rdu.redhat.com [172.16.50.73]) by pobox.corp.redhat.com (8.12.8/8.12.8) with ESMTP id k2RJvWTp022610 for ; Mon, 27 Mar 2006 14:57:32 -0500 Received: from ironwood.lan (ironwood.lan [192.168.64.8]) by localhost.localdomain (8.12.11/8.12.10) with ESMTP id k2RK1ElD028538 for ; Mon, 27 Mar 2006 13:01:14 -0700 Date: Tue, 28 Mar 2006 00:00:00 -0000 From: Kevin Buettner To: gdb-patches@sources.redhat.com Subject: Re: [RFA] solib-som.c fix for hpux Message-ID: <20060327125731.694bb85e@ironwood.lan> In-Reply-To: <20060324202315.GB26748@nevyn.them.org> References: <442382D1.4010104@tausq.org> <20060324202315.GB26748@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-03/txt/msg00311.txt.bz2 On Fri, 24 Mar 2006 15:23:15 -0500 Daniel Jacobowitz wrote: > On Fri, Mar 24, 2006 at 01:25:37PM +0800, Randolph Chung wrote: > > Dan J's change to solib handling > > (http://sources.redhat.com/ml/gdb-patches/2006-01/msg00198.html) exposed > > a probably unfounded assumption in the SOM solib code that assumes that > > the solib_create_inferior_hook will always be called before current_sos. > > As a result, gdb cvs on HPUX 32-bit would always error out when trying > > to run any executable with the message "Debugging dynamic executables > > loaded via the hpux8 dld.sl is not supported.". The most straightforward > > fix is to remove the error and handle the case where there is not yet a > > link map; that is what I have in the patch below. OTOH this does remove > > the error message if anybody does try to run gdb on hpux8 (!!!) > > Grr! I tried to catch all of these. Some assume that add is called > first... others assume that create is called first... > > > 2006-03-24 Randolph Chung > > > > * solib-som.c (link_map_start): Don't error out if there is > > not yet a link map. > > It seems OK to me, but I don't want to approve SOM changes; maybe get > Kevin's opinion, since this is a shared library topic? It looks okay to me too. Kevin