Re: [PATCH] Don't call Insight hooks when not appropriate

Andrew STUBBS
2006-03-10T11:18:23Z

Daniel Jacobowitz wrote:
> On Thu, Mar 09, 2006 at 08:10:56PM +0100, Mark Kettenis wrote:
>>> Date: Thu, 09 Mar 2006 15:37:22 +0000
>>> From: Andrew STUBBS <andrew.stubbs@st.com>
>>>
>>> 2006-03-09 Andrew Stubbs <andrew.stubbs@st.com>
>>>
>>> * cli/cli-script.c (execute_user_command): Set instream to -1, not 0.
>>> (read_command_lines): Check instream before calling the prompt hook.
>> I think this usage of -1 is a bad idea.
>
> Me too. We're already using a global variable; why not just add
> another and restore it in the same cleanup?

I don't really mind, as long as it works.

How would you like it done?

Andrew