From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3329 invoked by alias); 23 Mar 2006 04:55:35 -0000 Received: (qmail 3312 invoked by uid 22791); 23 Mar 2006 04:55:34 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Thu, 23 Mar 2006 04:55:33 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1FMHr2-0008JL-Uy; Wed, 22 Mar 2006 23:55:25 -0500 Date: Thu, 23 Mar 2006 05:24:00 -0000 From: Daniel Jacobowitz To: Jim Blandy Cc: gdb-patches@sources.redhat.com Subject: Re: RFA: prologue value modules Message-ID: <20060323045524.GA31868@nevyn.them.org> Mail-Followup-To: Jim Blandy , gdb-patches@sources.redhat.com References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.8i X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-03/txt/msg00253.txt.bz2 On Wed, Mar 22, 2006 at 08:37:20PM -0800, Jim Blandy wrote: > Okay to commit? As far as I'm concerned, yes; anyone else have comments on the new code? > * prologue-value.c, prologue-value.h: New files. > * Makefile.in (prologue_value_h): New variable. > (HFILES_NO_SRCDIR): List prologue-value.h. > (ALLDEPFILES): List prologue-value.c. > (prologue-value.o): New rule. Hmm - why not always build it? It won't get linked in if nothing needs it, and then ports won't need to mention it in TDEPFILES. And that'll encourage people to use it I hope :-) The other port I was using this code for was ARM - I only rewrote the Thumb analyzer, not the ARM one, but it was simpler and better. Once this goes in I may try to find some time to do ARM mode too, and submit it. -- Daniel Jacobowitz CodeSourcery