From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30809 invoked by alias); 17 Mar 2006 19:12:14 -0000 Received: (qmail 30792 invoked by uid 22791); 17 Mar 2006 19:12:14 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Fri, 17 Mar 2006 19:12:12 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1FKKMp-00050n-OT; Fri, 17 Mar 2006 14:12:07 -0500 Date: Fri, 17 Mar 2006 19:41:00 -0000 From: Daniel Jacobowitz To: Vladimir Prus Cc: gdb-patches@sources.redhat.com Subject: Re: MI: type prefixes for values Message-ID: <20060317191207.GA19068@nevyn.them.org> Mail-Followup-To: Vladimir Prus , gdb-patches@sources.redhat.com References: <17427.54333.236860.258115@kahikatea.snap.net.nz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.8i X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-03/txt/msg00230.txt.bz2 On Fri, Mar 17, 2006 at 07:07:17PM +0300, Vladimir Prus wrote: > Nick Roberts wrote: > > > 2006-03-12 Nick Roberts > > > > * mi/mi-cmd-stack.c (list_args_or_locals): Use common_val_print > > instead of print_variable_value so that type doesn't get printed > > with value. > > This patch is much more important that value formatting, in fact. Without > it, if there's local reference variable that's no initialized, we get this > output from gdb: > > (gdb) -stack-list-locals --all-values > Cannot access memory at address 0x1 > ^error,msg="Cannot access memory at address 0x1" > > Essentially, I can't see any local variables. This patch fixes this too, > because, I believe, common_val_print does check for non-dereferencable > values. Changelogs say common_val_print was specifically added for this > purpose. Did you try this? I don't think it will: common_val_print was added for the optimized-out case, not for the memory-error case, which should be handled somewhere else. -- Daniel Jacobowitz CodeSourcery