From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27191 invoked by alias); 15 Mar 2006 22:59:46 -0000 Received: (qmail 27182 invoked by uid 22791); 15 Mar 2006 22:59:45 -0000 X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (82.92.89.47) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 15 Mar 2006 22:59:44 +0000 Received: from elgar.sibelius.xs4all.nl (root@elgar.sibelius.xs4all.nl [192.168.0.2]) by sibelius.xs4all.nl (8.13.4/8.13.4) with ESMTP id k2FMxAdo006531; Wed, 15 Mar 2006 23:59:10 +0100 (CET) Received: from elgar.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) by elgar.sibelius.xs4all.nl (8.13.4/8.13.3) with ESMTP id k2FMx9jt022213; Wed, 15 Mar 2006 23:59:09 +0100 (CET) Received: (from kettenis@localhost) by elgar.sibelius.xs4all.nl (8.13.4/8.13.4/Submit) id k2FMx9iY018884; Wed, 15 Mar 2006 23:59:09 +0100 (CET) Date: Wed, 15 Mar 2006 23:40:00 -0000 Message-Id: <200603152259.k2FMx9iY018884@elgar.sibelius.xs4all.nl> From: Mark Kettenis To: drow@false.org CC: gdb-patches@sourceware.org In-reply-to: <20060315223629.GA25509@nevyn.them.org> (message from Daniel Jacobowitz on Wed, 15 Mar 2006 17:36:29 -0500) Subject: Re: RFC: Correct "paddr_t" in gdb_proc_service.h References: <20060315163650.GA16226@nevyn.them.org> <200603152234.k2FMY7kd008466@elgar.sibelius.xs4all.nl> <20060315223629.GA25509@nevyn.them.org> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-03/txt/msg00208.txt.bz2 > Date: Wed, 15 Mar 2006 17:36:29 -0500 > From: Daniel Jacobowitz > > > > When I wrote this patch (last year) I went through the original changelog > > > entries for this file from 2000; they suggest that this change is correct > > > and there should be no paddr_t references in GDB. > > > > I think that's right, and therefore I don't understand your change > > at all :(. > > Well, we do have paddr_t references. Want me to replace them all with > psaddr_t references while I'm here? (The same casts will still be > necessary, since again, psaddr_t is a pointer type.) Yes, I think you should. And it looks like we really need a standard function to convert a native pointer to a CORE_ADDR in gdb. Mark