Re: [commit] Clean up proc-service includes in gdbserver

Daniel Jacobowitz
2006-03-15T19:51:26Z

On Wed, Mar 15, 2006 at 11:48:09AM -0800, Michael Snyder wrote:
> Daniel Jacobowitz wrote:
> >A while ago, I posted MIPS and ARM NPTL support for gdbserver.
> >Before I got around to checking it in, Mark K. looked at one of
> >them and went "ewwww..."; it was just copied from three other places
> >in gdbserver, but I totally agree with his reaction. So this patch
> >un-ewwws things a bit. Instead of borrowing gdb_proc_service.h
> >from gdb, this patch gives gdbserver its own, slightly different
> >copy.
> >
> >We don't use the prfpregset_t functions at all, so we can lose some
> >old autoconf checks, too.
> >
> >Tested and committed.
> >
>
> If gdb_proc_service.h is shared between gdb and gdbserver,
> should we move it up to ../include/gdb?

That might be a good idea if they wanted to keep the same versions,
yes; but I've just diverged them, which I think will be simpler.
The GDB copy includes "gregset.h" and messes around with bits
from the GDB native configuration - bit hard to reuse.

--
Daniel Jacobowitz
CodeSourcery