Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Alexandre Oliva <aoliva@redhat.com>
Cc: Mark Kettenis <mark.kettenis@xs4all.nl>,
	gdb-patches@sources.redhat.com, 	roland@redhat.com
Subject: Re: Support Dwarf3 DW_CFA_val_* expressions
Date: Mon, 13 Mar 2006 02:25:00 -0000	[thread overview]
Message-ID: <20060311190811.GA26990@nevyn.them.org> (raw)
In-Reply-To: <ord5gyp2qv.fsf@free.oliva.athome.lsd.ic.unicamp.br>

On Tue, Mar 07, 2006 at 02:46:00PM -0300, Alexandre Oliva wrote:
> Using the address of the first instruction in the region wouldn't work
> either.  The hand-generated unwind info arranges for _L_mutex_lock_31
> on i386 to seem like it calls itself, for some reason I don't quite
> understand.  Jakub says the backtrace we get after my change is
> correct, whereas *without* the patch we get this:

Where does this hand generated unwind info come from?  The NPTL I'm
looking at doesn't have any for that function, either an older build I
had around or a current CVS checkout.  I'm very suspicious of your
description of it.

> > In any case, the frame ID should only change when
> > we really enter a different frame.
> 
> My understanding is that the intention *is* to represent debug info as
> an entry into a new frame, but I don't quite understand why it would
> be correct to have two entries for the same function, as in the stack
> trace below (generated by the incorrectly-patched GDB).

If the intention is to represent an entry into a new frame, then the
debugger should be displaying two frames.

> Tricky.  The very point of the tests is to test the complex CFA
> expressions.  I could easily remove all of the cleanup and run-time
> unwinding stuff (is this what you meant?), but taking out the hairy
> bits would render the test pointless.

Testing hand-written dwarf2/dwarf3 is entirely fine, even if we have to
arch-restrict the tests.

-- 
Daniel Jacobowitz
CodeSourcery


  parent reply	other threads:[~2006-03-11 19:08 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-03 17:54 Alexandre Oliva
2006-03-04 12:01 ` Mark Kettenis
2006-03-04 14:43   ` Alexandre Oliva
2006-03-04 15:07     ` Daniel Jacobowitz
2006-03-07 14:25       ` Alexandre Oliva
2006-03-07 15:01         ` Mark Kettenis
2006-03-07 19:55           ` Alexandre Oliva
2006-03-12 18:15             ` Mark Kettenis
2006-05-28 22:22               ` Alexandre Oliva
2006-03-13  2:25             ` Daniel Jacobowitz [this message]
2006-03-13  6:23               ` Alexandre Oliva
2006-03-24 23:08                 ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060311190811.GA26990@nevyn.them.org \
    --to=drow@false.org \
    --cc=aoliva@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=mark.kettenis@xs4all.nl \
    --cc=roland@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox