From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16400 invoked by alias); 9 Mar 2006 19:14:36 -0000 Received: (qmail 16387 invoked by uid 22791); 9 Mar 2006 19:14:36 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Thu, 09 Mar 2006 19:14:31 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1FHQag-00088M-Vs; Thu, 09 Mar 2006 14:14:27 -0500 Date: Thu, 09 Mar 2006 20:04:00 -0000 From: Daniel Jacobowitz To: Mark Kettenis , andrew.stubbs@st.com, gdb-patches@sourceware.org, insight@sourceware.org Subject: Re: [PATCH] Don't call Insight hooks when not appropriate Message-ID: <20060309191426.GA31250@nevyn.them.org> Mail-Followup-To: Mark Kettenis , andrew.stubbs@st.com, gdb-patches@sourceware.org, insight@sourceware.org References: <44104BB2.6000108@st.com> <200603091910.k29JAucq014442@elgar.sibelius.xs4all.nl> <20060309191304.GA31165@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060309191304.GA31165@nevyn.them.org> User-Agent: Mutt/1.5.8i X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-03/txt/msg00144.txt.bz2 On Thu, Mar 09, 2006 at 02:13:04PM -0500, Daniel Jacobowitz wrote: > On Thu, Mar 09, 2006 at 08:10:56PM +0100, Mark Kettenis wrote: > > > Date: Thu, 09 Mar 2006 15:37:22 +0000 > > > From: Andrew STUBBS > > > > > > 2006-03-09 Andrew Stubbs > > > > > > * cli/cli-script.c (execute_user_command): Set instream to -1, not 0. > > > (read_command_lines): Check instream before calling the prompt hook. > > > > I think this usage of -1 is a bad idea. > > Me too. We're already using a global variable; why not just add > another and restore it in the same cleanup? Or maybe make the existing user_call_depth global. -- Daniel Jacobowitz CodeSourcery