From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14961 invoked by alias); 9 Mar 2006 19:11:01 -0000 Received: (qmail 14947 invoked by uid 22791); 9 Mar 2006 19:11:00 -0000 X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (82.92.89.47) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 09 Mar 2006 19:11:00 +0000 Received: from elgar.sibelius.xs4all.nl (root@elgar.sibelius.xs4all.nl [192.168.0.2]) by sibelius.xs4all.nl (8.13.4/8.13.4) with ESMTP id k29JAu8B012192; Thu, 9 Mar 2006 20:10:56 +0100 (CET) Received: from elgar.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) by elgar.sibelius.xs4all.nl (8.13.4/8.13.3) with ESMTP id k29JAurI015096; Thu, 9 Mar 2006 20:10:56 +0100 (CET) Received: (from kettenis@localhost) by elgar.sibelius.xs4all.nl (8.13.4/8.13.4/Submit) id k29JAucq014442; Thu, 9 Mar 2006 20:10:56 +0100 (CET) Date: Thu, 09 Mar 2006 19:49:00 -0000 Message-Id: <200603091910.k29JAucq014442@elgar.sibelius.xs4all.nl> From: Mark Kettenis To: andrew.stubbs@st.com CC: gdb-patches@sourceware.org, insight@sourceware.org In-reply-to: <44104BB2.6000108@st.com> (message from Andrew STUBBS on Thu, 09 Mar 2006 15:37:22 +0000) Subject: Re: [PATCH] Don't call Insight hooks when not appropriate References: <44104BB2.6000108@st.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-03/txt/msg00142.txt.bz2 > Date: Thu, 09 Mar 2006 15:37:22 +0000 > From: Andrew STUBBS > > 2006-03-09 Andrew Stubbs > > * cli/cli-script.c (execute_user_command): Set instream to -1, not 0. > (read_command_lines): Check instream before calling the prompt hook. I think this usage of -1 is a bad idea. Mark