Re: RFC: Use the ARM CPSR as a fallback to determine ARM/Thumb

Eli Zaretskii
2008-05-02T10:17:35Z

> Date: Thu, 1 May 2008 14:38:05 -0400
> From: Daniel Jacobowitz <drow@false.org>
> Cc: Eli Zaretskii <eliz@gnu.org>
>
> Eli, do the documentation and NEWS changes look OK?

Yes, but I have a few comments:

> +@item set arm fallback-mode
> +This command sets the mode (ARM versus Thumb) which @value{GDBN} will
> +assume for code without a symbol table. The default is @samp{auto},
> +which causes @value{GDBN} to use the mode associated with the current
> +CPSR.

Please explain (in parens or in a @footnote) what is CPSR. There's no
other instance in the manual where this acronym is used.

Also, I think we should list all possible values of this option
explicitly. As written, the text forces the user to gather the values
incrementally (first ARM and Thumb, then auto), and leaves me
wondering whether there are more possible values.

> +set arm fallback-mode (arm|thumb|auto)
> +show arm fallback-mode
> +set arm force-mode (arm|thumb|auto)
> +show arm force-mode
> + These variables control how ARM GDB determines whether instructions
^^^^^^^^^
"commands", not "variables", I think.

> + are ARM or Thumb. The default for both settings is auto, which uses
> + the current CPSR value for instructions without symbols; previous
> + versions of GDB behaved as if "set arm fallback-mode arm".

Btw, I find this description much better than the one in gdb.texinfo:
here you explicitly talk about instructions, whereas in the manual the
description is much more abstract and doesn't even mention
instructions. Can we make the manual closer to NEWS in this sense?

Thanks.