Re: RFC: Use the ARM CPSR as a fallback to determine ARM/Thumb

Mark Kettenis
2006-03-02T22:23:18Z

> Date: Thu, 2 Mar 2006 17:14:46 -0500
> From: Daniel Jacobowitz <drow@false.org>
>
> On Tue, Feb 21, 2006 at 10:36:01AM -0500, Daniel Jacobowitz wrote:
> > What I had in mind for this was:
> >
> > set arm fallback-mode [arm|thumb|auto]
> >
> > That is, continue to honor symbol information, but change the fallback
> > when we don't have symbols to arm, thumb, or current cpsr.
> >
> > And maybe augment that with:
> >
> > set arm force-mode [arm|thumb|auto]
> >
> > This would also override symbol information.
> >
> > This is basically the same as your first option, but spread out over
> > two variables. How does that sound?
>
> Something like the attached; look OK?
>
> For correctness this needs the massive remove_breakpoint patch
> I'm posting next.

Hmm, this really should unwind CPSR from the frame I think. A bit
impractical to change that now, but something to keep in mind. Could
you add a FIXME that points this out if you agree?

> 2006-03-02 Daniel Jacobowitz <dan@codesourcery.com>
>
> * arm-tdep.c (arm_mode_strings, arm_fallback_mode_string)
> (arm_force_mode_string, arm_show_fallback_mode)
> (arm_show_force_mode): New.
> (arm_pc_is_thumb): Honor fallback-mode and force-mode.
> Fall back to the CPSR.
> (_initialize_arm_tdep): Add "set arm fallback-mode"
> and "set arm force-mode".
>
> 2006-03-02 Daniel Jacobowitz <dan@codesourcery.com>
>
> * gdb.texinfo (ARM): Document set/show arm fallback-mode
> and set/show arm force-mode.
>