From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19951 invoked by alias); 2 Mar 2006 22:52:37 -0000 Received: (qmail 19941 invoked by uid 22791); 2 Mar 2006 22:52:36 -0000 X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (82.92.89.47) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 02 Mar 2006 22:52:35 +0000 Received: from elgar.sibelius.xs4all.nl (root@elgar.sibelius.xs4all.nl [192.168.0.2]) by sibelius.xs4all.nl (8.13.4/8.13.4) with ESMTP id k22MptCK005613; Thu, 2 Mar 2006 23:51:55 +0100 (CET) Received: from elgar.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) by elgar.sibelius.xs4all.nl (8.13.4/8.13.3) with ESMTP id k22Mps30003035; Thu, 2 Mar 2006 23:51:54 +0100 (CET) Received: (from kettenis@localhost) by elgar.sibelius.xs4all.nl (8.13.4/8.13.4/Submit) id k22Mps0w023981; Thu, 2 Mar 2006 23:51:54 +0100 (CET) Date: Thu, 02 Mar 2006 23:10:00 -0000 Message-Id: <200603022251.k22Mps0w023981@elgar.sibelius.xs4all.nl> From: Mark Kettenis To: drow@false.org CC: rearnsha@arm.com, gdb-patches@sourceware.org, sjackman@gmail.com In-reply-to: <20060302222543.GA21332@nevyn.them.org> (message from Daniel Jacobowitz on Thu, 2 Mar 2006 17:25:43 -0500) Subject: Re: RFC: Use the ARM CPSR as a fallback to determine ARM/Thumb References: <20060220214918.GA28798@nevyn.them.org> <1140519913.27380.29.camel@pc960.cambridge.arm.com> <20060221153601.GA21183@nevyn.them.org> <20060302221446.GA18830@nevyn.them.org> <200603022222.k22MMQre000048@elgar.sibelius.xs4all.nl> <20060302222543.GA21332@nevyn.them.org> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-03/txt/msg00061.txt.bz2 > Date: Thu, 2 Mar 2006 17:25:43 -0500 > From: Daniel Jacobowitz > > On Thu, Mar 02, 2006 at 11:22:26PM +0100, Mark Kettenis wrote: > > Hmm, this really should unwind CPSR from the frame I think. A bit > > impractical to change that now, but something to keep in mind. Could > > you add a FIXME that points this out if you agree? > > But... what frame? Is there a relevant frame? I don't believe that > there is. This is used for things like breakpoints and explicit "x/i". > Maybe you see something I don't, though? It is possible for thumb code and "normal" code to coexist in a single address space isn't it? The prologue analyzer seems to use this, so if we're doing a backtrace, I think it should use the CPSR value for that frame, instead of whatever the current value for that register is. > Now, I could get it from get_current_frame() instead of read_register, > if you like. Well, that might be a good idea, because it is somewhat closer to what would be really correct. But adding the FIXME is enough to make me happy, since fixing things properly is clearly too much to ask for, and this patch really seems to be an improvement. Mark