From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14704 invoked by alias); 27 Feb 2006 23:31:02 -0000 Received: (qmail 14696 invoked by uid 22791); 27 Feb 2006 23:31:02 -0000 X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 27 Feb 2006 23:31:00 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id k1RNUwL7019014 for ; Mon, 27 Feb 2006 18:30:58 -0500 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id k1RNUr106242 for ; Mon, 27 Feb 2006 18:30:53 -0500 Received: from localhost.localdomain (vpn50-40.rdu.redhat.com [172.16.50.40]) by pobox.corp.redhat.com (8.12.8/8.12.8) with ESMTP id k1RNUrNr027756; Mon, 27 Feb 2006 18:30:53 -0500 Received: from ironwood.lan (ironwood.lan [192.168.64.8]) by localhost.localdomain (8.12.11/8.12.10) with ESMTP id k1RNWh7E001512; Mon, 27 Feb 2006 16:32:43 -0700 Date: Tue, 28 Feb 2006 01:50:00 -0000 From: Kevin Buettner To: gdb-patches@sources.redhat.com, Alexandre Oliva Subject: Re: cope with varying prelink base addresses Message-ID: <20060227163051.47456664@ironwood.lan> In-Reply-To: References: <20060220174327.GF19356@nevyn.them.org> <20060223202239.GA1520@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-02/txt/msg00502.txt.bz2 On Fri, 24 Feb 2006 01:42:46 -0300 Alexandre Oliva wrote: > On Feb 23, 2006, Daniel Jacobowitz wrote: > > > On Thu, Feb 23, 2006 at 05:18:11PM -0300, Alexandre Oliva wrote: > >> On Feb 20, 2006, Daniel Jacobowitz wrote: > >> > >> > The testcase behaves on Solaris, where there's no prelink binary. I'm > >> > a little worried about it being noisy where -shared doesn't work, > >> > and with various non-GCC tools. Maybe move the gcc_compiled check > >> > further up? > >> > >> Isn't gcc_compiled only set when you actually try to compile > >> something? That was my impression when I tried the test earlier, > >> before I submitted the first version of this patch. > > > Once upon a time get_compiler_info needed $binfile. Now the argument > > is ignored, so you can move get_compiler_info up before the > > compilation. > > Aha! Ok, this should work, then (tested on GNU/Linux/x86_64) > > Ok to install? Yes, please commit this patch. Kevin