Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Fred Fish <fnf@specifix.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Recognize and skip interpreter_p initialization in selftest.exp
Date: Sun, 26 Feb 2006 18:49:00 -0000	[thread overview]
Message-ID: <20060226184004.GA19823@nevyn.them.org> (raw)
In-Reply-To: <200602261335.28612.fnf@specifix.com>

On Sun, Feb 26, 2006 at 01:35:28PM -0500, Fred Fish wrote:
> With the latest development gcc and latest development gdb,
> selftest.exp fails because the breakpoint at captured_main gets set at
> the interpreter_p initialization, which isn't currently one of the
> recognized patterns.  Apparently optimization has gotten better and
> this code has been moved up the instruction stream:
> 
>   (gdb) br captured_main
>   Breakpoint 1 at 0x807c714: file /src/latest/trunk/src/gdb/gdb/main.c, line 241.
>   (gdb) run
>   Starting program: /links/build/latest/trunk/i686-pc-linux-gnu/gdb/gdb/gdb
>   Breakpoint 1, captured_main (data=0xbfdbb3f4) at /src/latest/trunk/src/gdb/gdb/main.c:241
>   241       interpreter_p = xstrdup (context->interpreter_p);

I'm not sure "better" is the word I'd use - how the heck did that
happen?  Could you please verify a couple of things for me: that we are
reasonably close to the beginning of the function, that the prologue
skipper hasn't gone too far, and that the instruction being executed
has actually got some relationship to line 241.

I've noticed some strange failures in this test recently too, but I
haven't had time to look into them.  It's entirely possible that
nothing's wrong and your patch is fine - I'm just being paranoid for
GCC and/or GDB bugs.


-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2006-02-26 18:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-26 18:40 Fred Fish
2006-02-26 18:49 ` Daniel Jacobowitz [this message]
2006-02-26 19:38   ` Fred Fish
2006-02-26 20:23     ` Mark Kettenis
2006-02-26 22:44       ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060226184004.GA19823@nevyn.them.org \
    --to=drow@false.org \
    --cc=fnf@specifix.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox