From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32023 invoked by alias); 20 Feb 2006 20:03:23 -0000 Received: (qmail 32015 invoked by uid 22791); 20 Feb 2006 20:03:22 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Mon, 20 Feb 2006 20:03:20 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1FBHFc-0006c3-1Q; Mon, 20 Feb 2006 15:03:16 -0500 Date: Mon, 20 Feb 2006 20:38:00 -0000 From: Daniel Jacobowitz To: Jim Blandy Cc: Andrew STUBBS , GDB Patches Subject: Re: [PATCH] Allow spaces in filenames to load command Message-ID: <20060220200315.GA25393@nevyn.them.org> Mail-Followup-To: Jim Blandy , Andrew STUBBS , GDB Patches References: <43949300.1040203@st.com> <8f2776cb0512051250u2a6083dbma95e6b352410dea8@mail.gmail.com> <43956C93.5070709@st.com> <8f2776cb0512061504la4a7a5brada0edaeb051f0e4@mail.gmail.com> <8f2776cb0512061912o2d37bef9y7404a51858bfd6cf@mail.gmail.com> <43971EC3.3060405@st.com> <43972145.6020903@st.com> <20060220170702.GH16058@nevyn.them.org> <8f2776cb0602201159r70222f70r538b97cdeb973e79@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8f2776cb0602201159r70222f70r538b97cdeb973e79@mail.gmail.com> User-Agent: Mutt/1.5.8i X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-02/txt/msg00382.txt.bz2 On Mon, Feb 20, 2006 at 11:59:42AM -0800, Jim Blandy wrote: > On 2/20/06, Daniel Jacobowitz wrote: > > On Wed, Dec 07, 2005 at 05:52:05PM +0000, Andrew STUBBS wrote: > > > 2005-12-07 Andrew Stubbs > > > > > > * symfile.c (generic_load): Use buildargv() and tilde_expand() > > > to parse file names with quoting, spaces and tildes properly. > > > (load_command): Quote all special characters before calling > > > target_load() such that buildargv() doesn't break file names. > > > (_initialize_symfile): Mention the load offset in the help for > > > the load command. > > > * remote-sim.c: Include readline.h. > > > (gdbsim_load): Use buildargv and tilde_expand() to parse file > > > names with quoting, spaces and tildes properly. > > > * target.h (target_load): Comment the parameters better. > > > * Makefile.in (remote_sim.o): Add readline.h dependency. > > > > This all looks plausible to me. Jim, do you want to take a look at > > this, since you were previously? > > Yes --- this look good. > > Ideally, the code added to load_command to do the quoting should be in > libiberty/argv.c. But this patch is fine as is. Good enough. We can deal with that separately, or just put it in utils.c, if we need it again. -- Daniel Jacobowitz CodeSourcery