From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30160 invoked by alias); 20 Feb 2006 19:19:42 -0000 Received: (qmail 29805 invoked by uid 22791); 20 Feb 2006 19:19:41 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Mon, 20 Feb 2006 19:19:40 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1FBGZN-000685-El; Mon, 20 Feb 2006 14:19:37 -0500 Date: Mon, 20 Feb 2006 19:19:00 -0000 From: Daniel Jacobowitz To: Andrew STUBBS Cc: GDB Patches Subject: Re: [PATCH] Allow spaces in pathnames to directory command Message-ID: <20060220191937.GA23330@nevyn.them.org> Mail-Followup-To: Andrew STUBBS , GDB Patches References: <4395AA58.90505@st.com> <4395AB73.2030704@st.com> <20060220171943.GA19356@nevyn.them.org> <43FA053B.6060502@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <43FA053B.6060502@st.com> User-Agent: Mutt/1.5.8i X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-02/txt/msg00377.txt.bz2 On Mon, Feb 20, 2006 at 06:06:51PM +0000, Andrew STUBBS wrote: > Daniel Jacobowitz wrote: > >On Tue, Dec 06, 2005 at 03:17:07PM +0000, Andrew STUBBS wrote: > >>Andrew Stubbs wrote: > >>>The directory command and the -d switch do not support pathnames that > >>>contain spaces. > >>It looks like my patch ought to fix PR gdb/1832, PR gdb/956, and perhaps > >>PR gdb/535. > > > >Does Andrew's comment about filename_completer in gdb/535 still apply? > > Yeah, I suppose it does. Certainly the auto-completer completes names > with spaces in (provided that the spaces are not in the part already > typed), but does not add any form of quoting. > > It doesn't quote quotes or spaces. Nor does it complete filenames that > have quoted elements already in them. > > This doesn't change the correctness of the patches in question though. > The bug report gdb/535 complains about the behaviour of generic_load(), > not the auto-completer - that's a separate issue raised by Andrew Cagney. > > I do agree that the completer ought to be fixed at some point. Except that previously, the filename completer produced things that were valid for this command, and now it doesn't. Sounds pretty inconvenient to me. I bumped up against this separately this morning. I may see about unifying the completion to handle quoting. -- Daniel Jacobowitz CodeSourcery