From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21722 invoked by alias); 20 Feb 2006 17:15:09 -0000 Received: (qmail 21712 invoked by uid 22791); 20 Feb 2006 17:15:08 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Mon, 20 Feb 2006 17:15:06 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1FBEcl-000528-HF; Mon, 20 Feb 2006 12:14:59 -0500 Date: Mon, 20 Feb 2006 17:15:00 -0000 From: Daniel Jacobowitz To: Andrew STUBBS Cc: GDB Patches Subject: Re: [PATCH] Allow spaces in filename to add-symbol-file command Message-ID: <20060220171459.GI16058@nevyn.them.org> Mail-Followup-To: Andrew STUBBS , GDB Patches References: <4395C45C.2090108@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4395C45C.2090108@st.com> User-Agent: Mutt/1.5.8i X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-02/txt/msg00367.txt.bz2 On Tue, Dec 06, 2005 at 05:03:24PM +0000, Andrew STUBBS wrote: > Hi, > > The war against missing space support continues! > > I have altered add_symbol_file_command() to use buildargv() instead of > parsing the arguments itself. This should allow quoting and hence spaces > in the filename. > > Additionally, I have reordered the help message so that 'help files' > uses the right part of the message and updated the testsuite to match. > > OK? > 2005-12-06 Andrew Stubbs > > * symfile.c (add_symbol_file_command): Use buildargv(), instead of > hand decoding the command line, to allow use of quotes and spaces. > (_initialize_symfile): Reorganize the help message for add-symbol-file > such that 'help files' shows a better message. > > testsuite/ > * gdb.base/help.exp (help add-symbol-file): Update. Yes, this is OK. Thanks. It is an incompatible change in one small corner-case - backslashes will suddenly be escaped for files without spaces, while previously they were not. But, the most prevalent file-related command is "file" (and "exec-file" and "symbol-file"), so I think following them is a good choice. Interestingly, var_filename calls tilde_expand, includes all remaining text on the line ignoring whitespace, and doesn't handle quotes or backslashes. Ditto for var_optional_filename (which is used for "set args" - what the heck?). Do we need to clean this up? :-( -- Daniel Jacobowitz CodeSourcery