Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: gdb-patches@sourceware.org
Subject: Re: [linux] Always ignore restart/cancellation signals
Date: Mon, 20 Feb 2006 17:01:00 -0000	[thread overview]
Message-ID: <20060220170147.GG16058@nevyn.them.org> (raw)
In-Reply-To: <20051208142420.GA21882@nevyn.them.org>

On Thu, Dec 08, 2005 at 09:24:20AM -0500, Daniel Jacobowitz wrote:
> The comment is fairly self-explanatory.  I guess I've always debugged
> failing cancellation tests with gdbserver, which hardwires these values
> already...
> 
> Any objections?

There were a few but they faded after discussion, so I have retested
and committed this patch.


-- 
Daniel Jacobowitz
CodeSourcery

2006-02-20  Daniel Jacobowitz  <dan@codesourcery.com>

	* linux-nat.c (lin_thread_get_thread_signals): Default to __SIGRTMIN
	and __SIGRTMIN + 1.

Index: gdb-6.4/gdb/linux-nat.c
===================================================================
--- gdb-6.4.orig/gdb/linux-nat.c	2005-11-03 14:51:40.000000000 -0500
+++ gdb-6.4/gdb/linux-nat.c	2005-12-07 21:44:12.000000000 -0500
@@ -3284,12 +3284,18 @@ lin_thread_get_thread_signals (sigset_t 
   sigemptyset (set);
 
   restart = get_signo ("__pthread_sig_restart");
+  cancel = get_signo ("__pthread_sig_cancel");
+
+  /* LinuxThreads normally uses the first two RT signals, but in some legacy
+     cases may use SIGUSR1/SIGUSR2.  NPTL always uses RT signals, but does
+     not provide any way for the debugger to query the signal numbers -
+     fortunately they don't change!  */
+
   if (restart == 0)
-    return;
+    restart = __SIGRTMIN;
 
-  cancel = get_signo ("__pthread_sig_cancel");
   if (cancel == 0)
-    return;
+    cancel = __SIGRTMIN + 1;
 
   sigaddset (set, restart);
   sigaddset (set, cancel);


      parent reply	other threads:[~2006-02-20 17:01 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-08 21:10 Daniel Jacobowitz
2005-12-09 10:39 ` Mark Kettenis
2005-12-09 11:09   ` Kevin Buettner
2005-12-09 11:26     ` Daniel Jacobowitz
2005-12-09 11:48       ` Kevin Buettner
2005-12-09 14:46       ` Eli Zaretskii
2005-12-09 20:52         ` Daniel Jacobowitz
2005-12-09 20:49           ` Daniel Jacobowitz
2005-12-09 21:55           ` Eli Zaretskii
2005-12-09 23:13             ` Daniel Jacobowitz
2005-12-10  1:20               ` Eli Zaretskii
2005-12-10  1:29                 ` Daniel Jacobowitz
2005-12-10  1:29                   ` Eli Zaretskii
2005-12-10  1:49                   ` Mark Kettenis
2005-12-10  2:10                     ` Daniel Jacobowitz
2005-12-10  4:47                       ` Mark Kettenis
2005-12-10  1:34         ` Jim Blandy
2005-12-11 17:26           ` Eli Zaretskii
2006-02-20 17:01 ` Daniel Jacobowitz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060220170147.GG16058@nevyn.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox