From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21013 invoked by alias); 20 Feb 2006 16:10:58 -0000 Received: (qmail 20965 invoked by uid 22791); 20 Feb 2006 16:10:57 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Mon, 20 Feb 2006 16:10:56 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1FBDcg-0004Tc-EZ; Mon, 20 Feb 2006 11:10:50 -0500 Date: Mon, 20 Feb 2006 16:10:00 -0000 From: Daniel Jacobowitz To: Wu Zhou Cc: gdb-patches@sources.redhat.com, Thomas.Koenig@online.de Subject: Re: [RFC]: Patch to support Fortran derived type - Revised Message-ID: <20060220161050.GE16058@nevyn.them.org> Mail-Followup-To: Wu Zhou , gdb-patches@sources.redhat.com, Thomas.Koenig@online.de References: <20051207232541.GB7483@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.8i X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-02/txt/msg00363.txt.bz2 On Sat, Dec 10, 2005 at 03:24:29PM +0800, Wu Zhou wrote: > > > +name : NAME > > > + { $$ = $1.stoken; } > > > + ; > > > + > > > > Why not just use name_not_typename instead of adding "name"? > > > > Also, the comments in name_not_typename don't apply here; you could > > also handle exp : exp % NAME_OR_INT as a name. But, I don't think that > > adds much value. The whole NAME_OR_INT thing seems like overkill. > > AFAICT, adding "name" might be a more direct and easier way to handle > that. I am not sure yet how to handle name_not_typename or NAME_OR_INT, > but it seems that some more work is needed in either the parsing or > evaluation phase. What is more, using "name" is the same way as that in > c and c++ expression parser, which looks to be more consistent. > > Does these make sense? I suppose. > 2005-12-10 Wu Zhou > > * gdb.fortran/derived-type.f90: New file. > * .fortran/derived-type.exp: New testcase. Typo there. > +++ gdb.fortran/derived-type.f90 16 Nov 2005 06:50:22 -0000 > @@ -0,0 +1,22 @@ > +program main Please add a copyright notice to all new tests. Otherwise the code and testcase look fine; Eli had some additional comments on the texinfo bits. -- Daniel Jacobowitz CodeSourcery