Re: Enhanced language support for Modula-2

Jim Blandy
2006-05-08T17:47:32Z

Gaius Mulley <gaius@glam.ac.uk> writes:
> "Jim Blandy" <jimb@red-bean.com> writes:
>
>> The revised patch looks fine. The only question I have is, what's up
>> with m2_type_print_base? Is that the way it's supposed to be?
>
> Hi,
>
> thanks for the feedback and here is the revised patch - which fixes
> the documentation:
>
> @example -> @smallexample
> @end example -> @end smallexample
> and uses the American spelling of `recogni[sz]ed'.
>
> and the code change removes the function m2_type_print_base and
> substitutes the call to it by a call to m2_print_type instead.

Okay, just some fine-toothed comb stuff:

Have you written ChangeLog entries for this? Follow the format the
other entries use.

In GDB code, each curly brace gets a line to itself. I see a few
sharing a line with an 'if' or 'else' in m2-valprint.c and
m2-typeprint.c.

Also, all GNU code should fit in eighty columns.

I see some indentation problems in m2_val_print. If you're using GNU
Emacs, just hit M-C-q before the function's opening brace, and it'll
take care of it.