From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-42907-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 24002 invoked by alias); 18 Feb 2006 11:19:09 -0000
Received: (qmail 23994 invoked by uid 22791); 18 Feb 2006 11:19:08 -0000
X-Spam-Check-By: sourceware.org
Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (82.92.89.47)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 18 Feb 2006 11:19:07 +0000
Received: from elgar.sibelius.xs4all.nl (root@elgar.sibelius.xs4all.nl [192.168.0.2]) 	by sibelius.xs4all.nl (8.13.4/8.13.4) with ESMTP id k1IBIwve012735; 	Sat, 18 Feb 2006 12:18:58 +0100 (CET)
Received: from elgar.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) 	by elgar.sibelius.xs4all.nl (8.13.4/8.13.3) with ESMTP id k1IBIwxp032218; 	Sat, 18 Feb 2006 12:18:58 +0100 (CET)
Received: (from kettenis@localhost) 	by elgar.sibelius.xs4all.nl (8.13.4/8.13.4/Submit) id k1IBIwNC028708; 	Sat, 18 Feb 2006 12:18:58 +0100 (CET)
Date: Sat, 18 Feb 2006 11:19:00 -0000
Message-Id: <200602181118.k1IBIwNC028708@elgar.sibelius.xs4all.nl>
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: eliz@gnu.org
CC: gdb-patches@sourceware.org, cygwin@cwilson.fastmail.fm
In-reply-to: <uy809eyin.fsf@gnu.org> (message from Eli Zaretskii on Sat, 18 	Feb 2006 12:45:20 +0200)
Subject: Re: RFA: ensure binary objects opened in binary mode
References: <43F6473F.8030508@cwilson.fastmail.fm> <20060217234141.GA1918@trixie.casa.cgf.cx> <uy809eyin.fsf@gnu.org>
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2006-02/txt/msg00345.txt.bz2

> Date: Sat, 18 Feb 2006 12:45:20 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> 
> > Date: Fri, 17 Feb 2006 18:41:41 -0500
> > From: Christopher Faylor <cgf-please-use-the-mailinglist@sourceware.org>
> > 
> > On Fri, Feb 17, 2006 at 04:59:27PM -0500, Charles Wilson wrote:
> > >2006-02-17  Charles Wilson  <...>
> > >
> > >	* gdb/solib.c(solib_open): ensure solib files are opened in
> > >	binary mode.
> > 
> > I think this patch is a good idea but I'm wondering if we're doing the
> > 
> > #ifdef O_BINARY
> > # define O_BINARY 0
> > #endif
> > 
> > trick in too many source files.  Maybe it's time for this to be in a header
> > file?
> 
> Agreed.  I think defs.h is a good place, do you agree?
> 
Problem is that right now defs.h doesn't include <fcntl.h> (where I
expect O_BINARY to be defined on systems that have it).  So we should
move that into fcntl.h as well (which is fine with me; we already
assume all systems have it, and we alredy include <unistd.h> from
defs.h).

Charles, one style nit: you need a space before and after the '|',
i.e. O_RDONLY | O_BINARY.

Mark