From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-42903-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 18245 invoked by alias); 17 Feb 2006 23:41:44 -0000
Received: (qmail 18234 invoked by uid 22791); 17 Feb 2006 23:41:43 -0000
X-Spam-Check-By: sourceware.org
Received: from cgf.cx (HELO cgf.cx) (24.61.23.223)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 17 Feb 2006 23:41:43 +0000
Received: by cgf.cx (Postfix, from userid 201) 	id 9A6F713C107; Fri, 17 Feb 2006 18:41:41 -0500 (EST)
Date: Fri, 17 Feb 2006 23:41:00 -0000
From: Christopher Faylor <cgf-please-use-the-mailinglist@sourceware.org>
To: gdb-patches@sourceware.org, Charles Wilson <cygwin@cwilson.fastmail.fm>
Subject: Re: RFA: ensure binary objects opened in binary mode
Message-ID: <20060217234141.GA1918@trixie.casa.cgf.cx>
Mail-Followup-To: gdb-patches@sourceware.org, 	Charles Wilson <cygwin@cwilson.fastmail.fm>
References: <43F6473F.8030508@cwilson.fastmail.fm>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <43F6473F.8030508@cwilson.fastmail.fm>
User-Agent: Mutt/1.5.11
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2006-02/txt/msg00341.txt.bz2

On Fri, Feb 17, 2006 at 04:59:27PM -0500, Charles Wilson wrote:
>2006-02-17  Charles Wilson  <...>
>
>	* gdb/solib.c(solib_open): ensure solib files are opened in
>	binary mode.

I think this patch is a good idea but I'm wondering if we're doing the

#ifdef O_BINARY
# define O_BINARY 0
#endif

trick in too many source files.  Maybe it's time for this to be in a header
file?

cgf