From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13549 invoked by alias); 16 Feb 2006 22:17:31 -0000 Received: (qmail 13539 invoked by uid 22791); 16 Feb 2006 22:17:30 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Thu, 16 Feb 2006 22:17:29 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1F9rRG-0000Iu-TN for gdb-patches@sourceware.org; Thu, 16 Feb 2006 17:17:26 -0500 Date: Thu, 16 Feb 2006 22:17:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sourceware.org Subject: Re: RFC: Fix an infinite loop placing sections in relocatable objects Message-ID: <20060216221726.GA1137@nevyn.them.org> Mail-Followup-To: gdb-patches@sourceware.org References: <20060216152444.GA22371@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.8i X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-02/txt/msg00329.txt.bz2 On Thu, Feb 16, 2006 at 11:04:31PM +0100, Andreas Schwab wrote: > Daniel Jacobowitz writes: > > > diff -u -p -r1.167 symfile.c > > --- symfile.c 7 Feb 2006 19:40:30 -0000 1.167 > > +++ symfile.c 16 Feb 2006 15:21:43 -0000 > > @@ -476,6 +476,7 @@ place_section (bfd *abfd, asection *sect > > struct place_section_arg *arg = obj; > > CORE_ADDR *offsets = arg->offsets->offsets, start_addr; > > int done; > > + ULONGEST align = 1 << bfd_get_section_alignment (abfd, sect); > > I think bfd_get_section_alignment can return values bigger than 31 in > general, and this is undefined in this case. It's only used in math with a CORE_ADDR, which will be the size of a bfd_vma. Can bfd_get_section_alignment return a shift greater than the size of a bfd_vma? What would that mean? -- Daniel Jacobowitz CodeSourcery