From: Paul Brook <paul@codesourcery.com>
To: gdb-patches@sourceware.org
Subject: [patch] Arm prologe skipping broken on 64-bit hosts
Date: Wed, 15 Feb 2006 01:37:00 -0000 [thread overview]
Message-ID: <200602150137.21894.paul@codesourcery.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 567 bytes --]
The Arm prologue skipping code is broken on 64-bit hosts. The problem is that
the opcode is loaded as a signed integer, then stored in an "unsigned long".
This is then compared against unsigned 32-bit constants.
The attached patch fixes this by reading the instruction as an unsigned value.
For consistency I made the same change in other similar routines.
Tested with cross to arm-none-eabi.
Ok?
Paul
2006-02-15 Paul Brook <paul@codesourcery.com>
* arm-tdep.c (arm_skip_prologue, thumb_get_next_pc, arm_get_next_pc):
Load insn opcodes as unsigned values.
[-- Attachment #2: commit.gdb_host64 --]
[-- Type: text/plain, Size: 159 bytes --]
2006-02-15 Paul Brook <paul@codesourcery.com>
* arm-tdep.c (arm_skip_prologue, thumb_get_next_pc, arm_get_next_pc):
Load insn opcodes as unsigned values.
next reply other threads:[~2006-02-15 1:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-15 1:37 Paul Brook [this message]
2006-02-15 3:02 ` Paul Brook
2006-02-15 11:34 ` Richard Earnshaw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200602150137.21894.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox