From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6316 invoked by alias); 10 Feb 2006 20:46:37 -0000 Received: (qmail 6187 invoked by uid 22791); 10 Feb 2006 20:46:35 -0000 X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (82.92.89.47) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 10 Feb 2006 20:46:33 +0000 Received: from elgar.sibelius.xs4all.nl (root@elgar.sibelius.xs4all.nl [192.168.0.2]) by sibelius.xs4all.nl (8.13.4/8.13.4) with ESMTP id k1AKjwEr024345; Fri, 10 Feb 2006 21:45:58 +0100 (CET) Received: from elgar.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) by elgar.sibelius.xs4all.nl (8.13.4/8.13.3) with ESMTP id k1AKjw7g021504; Fri, 10 Feb 2006 21:45:58 +0100 (CET) Received: (from kettenis@localhost) by elgar.sibelius.xs4all.nl (8.13.4/8.13.4/Submit) id k1AKjw3R004870; Fri, 10 Feb 2006 21:45:58 +0100 (CET) Date: Fri, 10 Feb 2006 20:46:00 -0000 Message-Id: <200602102045.k1AKjw3R004870@elgar.sibelius.xs4all.nl> From: Mark Kettenis To: drow@false.org CC: gdb-patches@sourceware.org In-reply-to: <20060209223832.GB3865@nevyn.them.org> (message from Daniel Jacobowitz on Thu, 9 Feb 2006 17:38:32 -0500) Subject: Re: RFA: Various Windows (mingw32) additions, mostly relating to select or serial ports References: <20060203220529.GA3578@nevyn.them.org> <20060206210238.GB28917@nevyn.them.org> <200602062301.k16N1hdu008774@elgar.sibelius.xs4all.nl> <20060209223832.GB3865@nevyn.them.org> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-02/txt/msg00257.txt.bz2 > Date: Thu, 9 Feb 2006 17:38:32 -0500 > From: Daniel Jacobowitz > > Here's a version that puts gdb_select off in its own file, and uses it > everywhere that it can be used (which does not include ser-tcp.c, > sorry). It's a pity ser-tcp.c can't use it. Can you add a comment explaining why? Otherwise, this looks fine to me (and the safe_strerror patch looks fine too). Thanks for doing this. Mark