From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28490 invoked by alias); 6 Feb 2006 23:21:26 -0000 Received: (qmail 28482 invoked by uid 22791); 6 Feb 2006 23:21:25 -0000 X-Spam-Check-By: sourceware.org Received: from cgf.cx (HELO cgf.cx) (24.61.23.223) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 06 Feb 2006 23:21:25 +0000 Received: by cgf.cx (Postfix, from userid 201) id A372D13C0F8; Mon, 6 Feb 2006 18:21:23 -0500 (EST) Date: Mon, 06 Feb 2006 23:21:00 -0000 From: Christopher Faylor To: gdb-patches@sourceware.org Subject: Re: RFA: Various Windows (mingw32) additions, mostly relating to select or serial ports Message-ID: <20060206232123.GA19699@trixie.casa.cgf.cx> Mail-Followup-To: gdb-patches@sourceware.org References: <20060203220529.GA3578@nevyn.them.org> <20060206210238.GB28917@nevyn.them.org> <200602062301.k16N1hdu008774@elgar.sibelius.xs4all.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200602062301.k16N1hdu008774@elgar.sibelius.xs4all.nl> User-Agent: Mutt/1.5.11 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-02/txt/msg00142.txt.bz2 On Tue, Feb 07, 2006 at 12:01:43AM +0100, Mark Kettenis wrote: >> Date: Mon, 6 Feb 2006 16:02:38 -0500 >> From: Daniel Jacobowitz >> >> On Fri, Feb 03, 2006 at 05:05:29PM -0500, Daniel Jacobowitz wrote: >> > Fixes, all for a mingw32-hosted GDB: >> >> Here is a revised version, in which the Windows select magic does not >> live in event-loop.c, and including the NEWS entry. I haven't changed >> the pipe polling code; thanks to Ian for his suggestions, but I'm >> not sufficiently sure they're workable. >> >> Are there any bits of this patch that strike you as too ugly or in the >> wrong place? > >Hmm, can't mingw_select() just be called select()? That'd remove much >of the ugliness. Unfortunately, there's already a select, with similar semantics to UNIX, exported by Windows's winsock dll. It can only be used for sockets, though. It's not useful for anything else. cgf